jenkins_job - added validate_certs parameter, setting the PYTHONHTTPSVERIFY env var #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
community_review
feature
felixfontein
reviewed
Mar 7, 2021
Co-authored-by: Felix Fontein <[email protected]>
Andersson007
reviewed
Mar 9, 2021
|
@russoz does this PR allow to change the default behavior, so nothing will break down for current users? |
|
@Andersson007 yep, default behaviour remains the same (that would be the default |
Andersson007
approved these changes
Mar 11, 2021
felixfontein
added
backport-2
check-before-release
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Mar 11, 2021
patchback bot
pushed a commit
that referenced
this pull request
Mar 11, 2021
…VERIFY env var (#1977) * added validate_certs parameter, setting the PYTHONHTTPSVERIFY env var * added changelog fragment * Update plugins/modules/web_infrastructure/jenkins_job.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/web_infrastructure/jenkins_job.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 7452a53)
|
@russoz thanks for this contribution! |
felixfontein
removed
the
check-before-release
felixfontein
pushed a commit
that referenced
this pull request
Mar 12, 2021
…VERIFY env var (#1977) (#1996) * added validate_certs parameter, setting the PYTHONHTTPSVERIFY env var * added changelog fragment * Update plugins/modules/web_infrastructure/jenkins_job.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/web_infrastructure/jenkins_job.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 7452a53) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a
validate_certsparameter, with default toTrue, that can be used to disable the validation of SSL/TLS certificates when contacting the Jenkins server. Under the hood this translates into setting the environment variablePYTHONHTTPSVERIFY=0as described in #255 .Fixes: #255
ISSUE TYPE
COMPONENT NAME
plugins/modules/web_infrastructure/jenkins_job.py