OnePassword library assumes incorrectly that a field als an attribute 'value'

[wkleinheerenbrink]

Summary

When using the 'lookup' method to get a field value from a field in a OnePassword Vault, the method might raise a KeyError when trying to access the key 'value' on the field dict. Given a template in the OnePassword vault, a label for a field might exist without a value if the user has omitted this value on purpose.

Issue Type

Bug Report

Component Name

onepassword

Ansible Version

$ ansible --version
ansible [core 2.15.3]
  python version = 3.9.17 (main, Jun 20 2023, 17:20:08) [Clang 14.0.3 (clang-1403.0.22.14.1)] 
  jinja version = 3.0.1

Community.general Version

$ ansible-galaxy collection list community.general
community.general 7.3.0  
community.general 2.0.1  

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

1. Create a onepassword item
2. Add a field with a label 'some-omitted-property'
3. Leave the value empty
4. Add a rule lookup(..., 'some-omitted-property') to an ansible script
5. Run ansible

Expected Results

Empty (or None-like) value at the location of lookup(..., 'some-omitted-property')

Actual Results

KeyError("value", "value")

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• plugins/lookup/onepassword.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @azenk @samdoran @scottsb
click here for bot help

[samdoran]

Very good find. In the v1 class, the .get() method is used to protect against this.

Simple reproducer playbook

- hosts: localhost

  tasks:
    - debug:
        msg: "{{ lookup('onepassword', 'Dummy Login', field='some-omitted-property') }}"