slackpkg: wrong matching of package name in installation

[majekw]

SUMMARY

Current implementation of searching packages could give wrong and unexpected results.
Slackware packages name convention is: name-version-arch-build.t?z, but name could also contain -. Matching name with exactly 3 occurrence of - is impossible in glob().
For example it's not possible to install openssl package when openssl-solibs is installed as check finds later matching desired pattern and module do nothing.

There was a try to fix this and also other issues with this module in ansible/ansible#22285 but this PR was abandoned and never finished.

ISSUE TYPE

• Bug Report

COMPONENT NAME

slackpkg

ANSIBLE VERSION

ansible 2.9.9

CONFIGURATION

OS / ENVIRONMENT

Slackware Linux 14.2

STEPS TO REPRODUCE

On system with openssl-solibs installed try to install also openssl package

  - name: install openssl package
    slackpkg:
      name: openssl
      state: present

EXPECTED RESULTS

Package openssl is installed if not present.

ACTUAL RESULTS

Package openssl is not installed because module 'thinks' that it's already present.

ok: [somehost] => {
    "changed": false,
    "invocation": {
        "module_args": {
            "name": [
                "openssl"
            ],
            "state": "present",
            "update_cache": false
        }
    },
    "msg": "package(s) already present"
}

[ansibullbot]

Files identified in the description:

• plugins/modules/packaging/os/slackpkg.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @KimNorgaard @bcoca @danowar2k @fishman @jasperla @jpdasma @mator @mavit @scathatheworm @troy2914 @xen0l
click here for bot help

[Andersson007]

closed via #450