-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sysctls option to docker_swarm_service #836
Conversation
This is my first time contributing to this project. Don't hesitate to tell me if I'm missing something / doing something wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you add a changelog fragment? Thanks.
You also need to add a new entry for sysctls
to option_minimal_versions
(line 2747). The required API version is apparently 1.40, and it has been added to Docker SDK for Python 6.0.0 according to docker/docker-py@58aa62b.
You also need to adjust the integration tests. You probably have to add |
Co-authored-by: Felix Fontein <[email protected]>
Thank you for the feedback, I made the requested changes |
Thanks, looks good to me! If nobody objects, I'll merge this in ~a week. |
@NairolfL thanks for your contribution! |
SUMMARY
Add sysctls options to docker_swarm_service, as discussed in #190
ISSUE TYPE
COMPONENT NAME
docker_swarm_service
ADDITIONAL INFORMATION