Change Docker Stack modules to use common CLI module framework #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
stack
branch
2 times, most recently
from
695c9af to
3de4712
Compare
|
If nobody objects, I'll merge this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now that we have a common CLI module framework (created for docker_image_build and docker_compose_v2), it's time to make the Docker Stack modules use it. This allows to configure several aspects with module options (Docker host to use, configure TLS, etc.) that had to be configured by environment variables before.
ISSUE TYPE
COMPONENT NAME
docker_stack
docker_stack_info
docker_stack_task_info