-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(community.docker.docker_volume): labels can be none #702
Conversation
catch case where volume labels can are done (default) eg: $ docker volume inspect foo [ { "CreatedAt": "2023-11-11T12:55:23+01:00", "Driver": "local", "Labels": null, "Mountpoint": "/var/lib/docker/volumes/foo/_data", "Name": "foo", "Options": {}, "Scope": "local" } ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you please add a changelog fragment? Thanks!
Co-authored-by: Felix Fontein <[email protected]>
Updated the PR with some documentation and the missing changelog fragment. |
Co-authored-by: Felix Fontein <[email protected]>
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #704 🤖 @patchback |
* fix(community.docker.docker_volume): labels can be none catch case where volume labels can are done (default) eg: $ docker volume inspect foo [ { "CreatedAt": "2023-11-11T12:55:23+01:00", "Driver": "local", "Labels": null, "Mountpoint": "/var/lib/docker/volumes/foo/_data", "Name": "foo", "Options": {}, "Scope": "local" } ] * Update plugins/modules/docker_volume.py Co-authored-by: Felix Fontein <[email protected]> * add(community.docker.docker_volume): changelog fragment * Update changelogs/fragments/702-docker-volume-label-none.yaml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 4c220c4)
@chaoslion thanks a lot for fixing this! |
* fix(community.docker.docker_volume): labels can be none catch case where volume labels can are done (default) eg: $ docker volume inspect foo [ { "CreatedAt": "2023-11-11T12:55:23+01:00", "Driver": "local", "Labels": null, "Mountpoint": "/var/lib/docker/volumes/foo/_data", "Name": "foo", "Options": {}, "Scope": "local" } ] * Update plugins/modules/docker_volume.py Co-authored-by: Felix Fontein <[email protected]> * add(community.docker.docker_volume): changelog fragment * Update changelogs/fragments/702-docker-volume-label-none.yaml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 4c220c4)
* fix(community.docker.docker_volume): labels can be none catch case where volume labels can are done (default) eg: $ docker volume inspect foo [ { "CreatedAt": "2023-11-11T12:55:23+01:00", "Driver": "local", "Labels": null, "Mountpoint": "/var/lib/docker/volumes/foo/_data", "Name": "foo", "Options": {}, "Scope": "local" } ] * Update plugins/modules/docker_volume.py Co-authored-by: Felix Fontein <[email protected]> * add(community.docker.docker_volume): changelog fragment * Update changelogs/fragments/702-docker-volume-label-none.yaml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 4c220c4) Co-authored-by: Alexander Jähnel <[email protected]>
Sure thing :) |
Catch case where volume labels can be None (it`s the default when creating a volume).
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION