vendored Docker SDK for Python code: update to latest version #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to return data, not size. By returning an empty string, EOF will be detected properly since `len()` will be `0`. Fixes docker/docker-py#3098. Cherry-picked from docker/docker-py@f846232 Co-authored-by: Milas Bowman <[email protected]>
…er-py#2865) Fixes docker/docker-py#2278, which was originally addressed in docker/docker-py#2279, but was not properly merged. Additionally it did not address the problem of poll not existing on Windows. This patch falls back on the more limited select method if host system is Windows. Cherry-picked from docker/docker-py@a02ba74 Co-authored-by: Tyler Westland <[email protected]>
Cherry-picked from docker/docker-py@9cadad0 Co-authored-by: Imogen <[email protected]>
…3125) Only listen to read events when polling a socket in order to avoid incorrectly trying to read from a socket that is not actually ready. Cherry-picked from docker/docker-py@c5e582c Co-authored-by: Loïc Leyendecker <[email protected]>
mariolenz
reviewed
May 20, 2023
There was a problem hiding this comment.
I don't want to approve because I don't know this collection. So I'm not really sure what those changes really mean.
But it looks like they're the same as docker/docker-py#2865, docker/docker-py#3099 and docker/docker-py#3112. If they're fine for the official Docker SDK for Python, I guess they're OK for this collection, too.
|
@mariolenz thanks a lot for checking the commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
All bugfixes in docker/docker-py@aca129d...bc4c0d7 that we don't already have. (There is no feature in that range that affects the vendored code.)
Ref: #435.
ISSUE TYPE
COMPONENT NAME
vendored Docker SDK for Python code