docker_container: cgroup_parent #59
Conversation
|
@WojciechowskiPiotr if you have time, can you take a quick look at this PR and #58? |
| @@ -52,6 +52,11 @@ | |||
| - List of capabilities to drop from the container. | |||
| type: list | |||
| elements: str | |||
| cgroup_parent: | |||
| description: | |||
| - Specify the parent cgroup for the container. | |||
There was a problem hiding this comment.
I see in the tests you added alongside you pass an empty string, what does it do? perhaps it should be added this is supported and the behaviour ?
There was a problem hiding this comment.
Well, the test doesn't really do anything :) The problem with testing this properly in integration tests is that you need to know which cgroups are around on the systems you run the tests on, which is pretty much impossible since they can run on any system (if you run ansible-test integration --docker xxx locally, your own docker daemon will be used, and thus it depends on your local system). That's why I put in an empty string, which by the module is treated as "value specified by user", but by the Docker daemon as "no value supplied" resp. "user does not care whether/which cgroup parent to use". This test mainly makes sure that all related code is run through at least once.
|
@bmillemathias @tadeboro thanks a lot for reviewing this! |
SUMMARY
Fixes #6.
Unfortunately cgroup_parent is pretty much undocumented, the docs do not seem to mention it at all. The feature was added in Docker SDK for Python 1.4.0 (docker/docker-py@3caaa00), so we can use it with all supported versions of the Docker SKD for Python (we require >= 1.8.0). It has already been mentioned in the API docs for 1.19 (https://docs.docker.com/engine/api/v1.19/#operation/ContainerCreate), so it should be available for all Docker API versions we support (>= 1.20).
This PR also mentions in all Docker SDK for Python based modules that they use the Docker SDK for Python to communicate with the docker daemon, since that is apparently unclear according to #6 ("Missing documentation how docker-container creates containers").
ISSUE TYPE
COMPONENT NAME
docker_container