fix: fix tmpfs_size and tmpfs_mode not being set #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristof-mattei
force-pushed
the
tmpfs_size-tmpfs_mode
branch
2 times, most recently
from
5e94a7f to
c41d9dc
Compare
kristof-mattei
force-pushed
the
tmpfs_size-tmpfs_mode
branch
from
c41d9dc to
438c697
Compare
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks!
tests/integration/targets/docker_swarm_service/tasks/tests/mounts.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Feb 10, 2023
|
@kristof-mattei thanks a lot for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug where
tmpfs_sizeandtmpfs_modeweren't correctly set on the Docker Container.ISSUE TYPE
COMPONENT NAME
Docker Container - parsing of
tmpfs_sizeandtmpfs_modeADDITIONAL INFORMATION