generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite docker_container to use Docker API directly #422
Merged
felixfontein
merged 38 commits into
ansible-collections:main
from
felixfontein:docker_container
Jul 15, 2022
Merged
Rewrite docker_container to use Docker API directly #422
felixfontein
merged 38 commits into
ansible-collections:main
from
felixfontein:docker_container
Jul 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ci_complete
ci_complete
This was referenced Aug 12, 2022
ghost
mentioned this pull request
Aug 12, 2022
1 task
1 task
This was referenced Aug 12, 2022
1 task
1 task
This was referenced Sep 25, 2022
1 task
This was referenced Oct 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
My last planned big part of #364: rewrite docker_container to use the Docker API directly (instead of Docker SDK for Python). It's not done yet, but it already passes all existing integration tests (at least it does so locally, let's see what CI says) :-) Some parts of it are very WIP, some already in a good state IMO.
ISSUE TYPE
COMPONENT NAME
docker_container