Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more compatible with podman-docker #292

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Make more compatible with podman-docker #292

merged 1 commit into from
Feb 11, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #291. With podman-docker, some more tricks need to be done to handle Docker short names such as redis...

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_image
docker_container

@felixfontein felixfontein mentioned this pull request Feb 4, 2022
Closed
@softwarefactory-project-zuul
Copy link

Build succeeded (third-party-check pipeline).

@felixfontein
Copy link
Collaborator Author

@mohd-akram it would be great if you could test this.

@mohd-akram
Copy link

@felixfontein Thanks for the prompt PR. Tried it out now and it works.

@felixfontein felixfontein changed the title [WIP] Make more compatible with podman-docker Make more compatible with podman-docker Feb 11, 2022
Andersson007
Andersson007 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 9cd46a7 into ansible-collections:main Feb 11, 2022
@felixfontein
Copy link
Collaborator Author

@mohd-akram thanks for testing this!
@Andersson007 thanks for reviewing!

@felixfontein felixfontein deleted the podman-docker branch February 11, 2022 11:23
@patchback
Copy link
Contributor

patchback bot commented Feb 11, 2022 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/9cd46a7d41c3fc717395735e99891132f2099710/pr-292

Backported as #298

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 11, 2022
@felixfontein @patchback
Try to make more compatible with podman-docker. (#292)
e4d68ed 
(cherry picked from commit 9cd46a7)
@patchback patchback bot mentioned this pull request Feb 11, 2022
Merged
felixfontein added a commit that referenced this pull request Feb 12, 2022
@patchback @felixfontein
Try to make more compatible with podman-docker. (#292) (#298)
febdace 
(cherry picked from commit 9cd46a7)

Co-authored-by: Felix Fontein <[email protected]>
@renovate renovate bot mentioned this pull request Feb 21, 2022
Merged
1 task
@wyoa-bot wyoa-bot bot mentioned this pull request Feb 21, 2022
Merged
1 task
This was referenced Feb 21, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 7, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman-docker: docker_image fails silently without archiving despite archive_path being specified
3 participants
@felixfontein @mohd-akram @Andersson007