Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of distutils.spawn #257

Merged

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Dec 22, 2021

SUMMARY

distutils has been deprecafed and will be removed from Python's stdlib in Python 3.12 (see https://www.python.org/dev/peps/pep-0632/). Let's stop using distutils.spawn.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker connection plugin

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

@felixfontein felixfontein merged commit 93ea131 into ansible-collections:main Dec 24, 2021
@patchback
Copy link
Contributor

patchback bot commented Dec 24, 2021

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/93ea131f306b135ce3821b792819da7de2a99707/pr-257

Backported as #259

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the remove-distutils branch December 24, 2021 10:27
patchback bot pushed a commit that referenced this pull request Dec 24, 2021
(cherry picked from commit 93ea131)
@felixfontein
Copy link
Collaborator Author

@briantist thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants