Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_container_exec: allow to specify environment #254

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #248.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_container_exec

@felixfontein
Copy link
Collaborator Author

felixfontein commented Dec 22, 2021

(Right now includes #253, will rebase once that's merged.)

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! No blocking questions or concerns.

plugins/modules/docker_container_exec.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 40576e3 into ansible-collections:main Dec 22, 2021
@felixfontein felixfontein deleted the exec-env branch December 22, 2021 16:56
@felixfontein
Copy link
Collaborator Author

@briantist thanks for also reviewing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --env in docker_container_exec
2 participants