Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_compose - Fix idempotency when services have no enabled profiles #192

Merged
merged 3 commits into from
Aug 20, 2021
Merged

docker_compose - Fix idempotency when services have no enabled profiles #192

merged 3 commits into from
Aug 20, 2021

Conversation

Ajpantuso
Copy link
Collaborator

SUMMARY

Adds a check before applying idempotency logic to services which have profiles defined, but none of which are enabled.

Fixes #191

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/docker_compose.py

ADDITIONAL INFORMATION
  • Uses the docker_compose library to perform the check.

@Ajpantuso Ajpantuso mentioned this pull request Aug 19, 2021
Closed
@Ajpantuso Ajpantuso changed the title [WIP] docker_compose - Fix idempotency when services have no enabled profiles docker_compose - Fix idempotency when services have no enabled profiles Aug 20, 2021
@Ajpantuso Ajpantuso marked this pull request as ready for review August 20, 2021 00:09
hummeltech
hummeltech approved these changes Aug 20, 2021
View reviewed changes
Copy link

@hummeltech hummeltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

felixfontein
felixfontein approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot say much about about docker-compose, but the change looks good to me.

@felixfontein felixfontein merged commit 4dfc3ae into ansible-collections:main Aug 20, 2021
@felixfontein
Copy link
Collaborator

@Ajpantuso thanks for fixing this!
@hummeltech thanks for reporting and testing this!

@Ajpantuso Ajpantuso deleted the docker_compose_profiles_idempotency_fix branch August 20, 2021 11:35
@felixfontein felixfontein mentioned this pull request Aug 27, 2021
Open
This was referenced Aug 29, 2021
Merged
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Sep 8, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hummeltech hummeltech hummeltech approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_compose: changed always true when profiles are present
3 participants
@Ajpantuso @felixfontein @hummeltech