Add SNI support to module get_certificates #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, now it found the new commits... |
For python versions supporting `create_default_context` support SNI by using low-level SSLContext.wrap_socket().getpeercert(). Add also more information in the error message fixes #69
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Jul 13, 2020
|
@bmillemathias thanks a lot for working on this! |
thanks for helping so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
drop get_server_certificates as it does not support SNI in favor of low-level
SSLContext.wrap_socket().getpeercert()Fixes #69
ISSUE TYPE
COMPONENT NAME
get_certificate