-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TLS/SSL CTX Options for the get_certificate Module #779
Merged
felixfontein
merged 11 commits into
ansible-collections:main
from
dlehrman:ssl-ctx-options
Jul 7, 2024
Merged
Enable TLS/SSL CTX Options for the get_certificate Module #779
felixfontein
merged 11 commits into
ansible-collections:main
from
dlehrman:ssl-ctx-options
Jul 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Ehrman <[email protected]>
Signed-off-by: David Ehrman <[email protected]>
dlehrman
commented
Jul 6, 2024
Signed-off-by: David Ehrman <[email protected]>
ssl_ctx_options can be a mix of str and int, but `elements: [ str, int ]` made the Ansible doc builder angry. Signed-off-by: David Ehrman <[email protected]>
felixfontein
reviewed
Jul 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Signed-off-by: David Ehrman <[email protected]>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Working on completing application of suggestions Co-authored-by: Felix Fontein <[email protected]>
Signed-off-by: David Ehrman <[email protected]>
dlehrman
changed the title
Enable SSL CTX Options for the get_certificate Module
Enable TLS/SSL CTX Options for the get_certificate Module
Jul 6, 2024
felixfontein
reviewed
Jul 7, 2024
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Signed-off-by: David Ehrman <[email protected]>
felixfontein
approved these changes
Jul 7, 2024
@dlehrman thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an option for TLS/SSL CTX options to the get_certificate module. Accepts both string (e.g. OP_LEGACY_SERVER_CONNECT) and integer (e.g. 4) representations for options as some options can be enabled via integer but not string, depending on the Python and/or OpenSSL/LibreSSL versions.
ISSUE TYPE
COMPONENT NAME
get_certificate
ADDITIONAL INFORMATION
I use Ansible to manage various device types (e.g. PDU's, BMC's, etc), some of which do not support secure renegotiation. For devices that do not support secure renegotiation, depending on the Ansible controller, the get_certificate module was experiencing an SSL failure, though I could still interact them with GUI web browsers (Chrome, Firefox).
Without manually enabling OP_LEGACY_SERVER_CONNECT (example endpoint uses 2048 bit cert, TLSv1.2 / AES128-GCM-SHA256, does not support secure renegotiation, cannot be changed):
After manually enabling OP_LEGACY_SERVER_CONNECT:
Relevant task:
Ansible controller properties: