-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto.math module utils: add some tests, fix quick_is_not_prime() for small primes #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r cases not happening in regular use.
Backport to stable-1: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 0c62837 on top of patchback/backports/stable-1/0c6283729632334a4fda10fba1d1a8422fa33052/pr-733 Backporting merged PR #733 into main
🤖 @patchback |
felixfontein
added a commit
to felixfontein/community.crypto
that referenced
this pull request
Apr 29, 2024
…r small primes (ansible-collections#733) * Fix quick_is_not_prime() for small primes. Add some tests. * Fix return value of convert_int_to_bytes(0, 0) on Python 2. * Add some more test cases. * Simplify the changelog and point out that these errors only happen for cases not happening in regular use. (cherry picked from commit 0c62837)
felixfontein
added a commit
that referenced
this pull request
Apr 29, 2024
…r small primes (#733) (#734) * Fix quick_is_not_prime() for small primes. Add some tests. * Fix return value of convert_int_to_bytes(0, 0) on Python 2. * Add some more test cases. * Simplify the changelog and point out that these errors only happen for cases not happening in regular use. (cherry picked from commit 0c62837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds basic unit tests for crypto.math module utils.
Fixes bug in quick_is_not_prime() that makes it claim that primes < 200 are not prime. This is due this function being designed to test large numbers, it was never meant to be used for such small numbers.
ISSUE TYPE
COMPONENT NAME
crypto.math module utils