action plugin helper: fix deprecation handling

[felixfontein]

SUMMARY

This is a consequence of ansible/ansible#79681 and ansible/ansible#79740, which were backported to stable-2.14 and released in ansible-core 2.14.2. Without these, there will be a crash when deprecations appear with ansible-core 2.14.2+ in action plugins using this helper.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

plugins/plugin_utils/action_module.py

[kristianheljas]

I kinda hate that there's a path now where deprecations could in theory be ignored (if name and msg both get missing), previously any scenario would be caught..

But it is consistent with ansible-core, so .. LGTM!

[felixfontein]

But it is consistent with ansible-core, so .. LGTM!

It's not anymore, ansible/ansible#79740 changed that code so that msg is always there.

I kinda hate that there's a path now where deprecations could in theory be ignored [...] previously any scenario would be caught..

Previously any scenario with ansible-core 2.14.2+ would result in a crash, I wouldn't exactly call that 'caught' ;-) But yeah, I'm not 100% happy with this. I think (hope) that ansible-core will stick to msg from now on, though, so I think it should be fine. (I guess, until it is not... but at least then it won't crash)

[patchback]

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/70c4585b88779a27861a60c55258cc47d5141f70/pr-572

Backported as #573

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@kristianheljas thanks a lot for reviewing this!