Add warning for ASN.1 encoded extension values returned by some modules #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les might not reflect the exact byte sequence in the source file anymore depending on the cryptography version.
Ajpantuso
requested changes
Oct 31, 2021
Co-authored-by: Ajpantuso <[email protected]>
|
@Ajpantuso thanks a lot for your feedback! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add warning that ASN.1 encoded extension values returned by some modules might not reflect the exact byte sequence in the source file anymore depending on the cryptography version.
(Related to pyca/cryptography#6346.)
We can potentially continue to use the current approach (using cffi and cryptography internals), but that might stop working at any moment and the functions we need for that might be removed from the cffi/cryptography exposed parts of OpenSSL.
On the other hand, once there is a stable interface to encode extension values, we have a lot less to worry about, and can also finally implement a feature which allows to specify arbitrary extension values for CSRs. (There was a feature request for that, but I can't find it anymore.)
I think it is important to announce this now (as a potentially breaking change) since we still haven't released 2.0.0 and thus can still have breaking changes "for free". Having them later in a bugfix or feature release is something we should really avoid.
ISSUE TYPE
COMPONENT NAME
get_certificate
openssl_csr_info
x509_certificate_info