Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssh_cert - Adding regenerate option #256

Merged
merged 13 commits into from
Jul 31, 2021
Merged

openssh_cert - Adding regenerate option #256

merged 13 commits into from
Jul 31, 2021

Conversation

Ajpantuso
Copy link
Collaborator

@Ajpantuso Ajpantuso commented Jul 16, 2021 •
edited
Loading

SUMMARY

Adds regenerate option to openssh_cert so that identifier, options, public_key, and signing_key are also checked for idempotency.
Implements #20

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/openssh_cert.py

ADDITIONAL INFORMATION
  • Defaults to pre 1.8.0 behavior to avoid a breaking_change
  • Minor changes to interfaces were made as well, but only to code releasing with 1.8.0

@Ajpantuso Ajpantuso force-pushed the openssh_idempotency_enhancements branch from e094cc6 to 978ca7c Compare July 16, 2021 23:47
@Ajpantuso Ajpantuso changed the title [WIP} openssh_cert - Adding idempotency option openssh_cert - Adding idempotency option Jul 17, 2021
@Ajpantuso Ajpantuso marked this pull request as ready for review July 17, 2021 00:26
@Ajpantuso Ajpantuso marked this pull request as draft July 17, 2021 12:21
@Ajpantuso Ajpantuso marked this pull request as ready for review July 17, 2021 15:26
@Ajpantuso Ajpantuso changed the title openssh_cert - Adding idempotency option openssh_cert - Adding regenerate option Jul 17, 2021
felixfontein
felixfontein reviewed Jul 21, 2021
View reviewed changes
plugins/module_utils/openssh/certificate.py Outdated Show resolved Hide resolved
plugins/modules/openssh_cert.py Outdated Show resolved Hide resolved
plugins/modules/openssh_cert.py Outdated Show resolved Hide resolved
felixfontein
felixfontein approved these changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

(Sorry for the delay, I forgot looking back here during/after vacation...)

@felixfontein felixfontein merged commit aaba87a into ansible-collections:main Jul 31, 2021
@Ajpantuso Ajpantuso deleted the openssh_idempotency_enhancements branch August 18, 2021 16:08
@renovate renovate bot mentioned this pull request Aug 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ajpantuso @felixfontein