Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openssl_pkcs12 crash with cryptography backend when loading passphrase-protected files #248

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #247. Also adds tests for this case to prevent regressions in the future.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/crypto/cryptography_support.py

Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 0df33de into ansible-collections:main Jun 11, 2021
@felixfontein felixfontein deleted the pkcs12 branch June 11, 2021 18:03
@felixfontein
Copy link
Contributor Author

@Ajpantuso thanks a lot for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PKCS#12 operations fail with "TypeError: password must be bytes-like" on the cryptography backend
2 participants