[PR #721/c91acf6a backport][stable-3] Extended the wafv2_web_acl module with custom_response_bodies argument #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
#721) Extended the wafv2_web_acl module with custom_response_bodies argument SUMMARY Extended the wafv2_web_acl module to also take the custom_response_bodies argument, improved docs and extended tests ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl ADDITIONAL INFORMATION Also touched docs of aws_waf_web_acl to make it easier to find the WAF v2 modules as I had trouble finding that at first. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Stefan Horning <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit c91acf6)
ansibullbot
added
community_review
feature
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/c91acf6a14c0aa69974241ead13223a84dbd5334/pr-721
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Bump botocore requirements SUMMARY Inline with the documented policy, bump botocore (and boto3/awscli) requirements for main branch ISSUE TYPE Feature Pull Request COMPONENT NAME README.md plugins/module_utils/modules.py requirements.txt tests/integration/constraints.txt tests/unit/constraints.txt ADDITIONAL INFORMATION (community.aws PRs will follow after the amazon.aws PRs are approved) [✔ mchappel@mchappel botocore] $ git show 1.21.0 tag 1.21.0 Tagger: aws-sdk-python-automation <[email protected]> Date: Thu Jul 15 18:08:47 2021 +0000 Tagging 1.21.0 release. Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Fix botocore bump changelog link SUMMARY Mistake in the changelog got ansible-collections#934 ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/botocore.yml ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #721 as merged into main (c91acf6).
SUMMARY
Extended the
wafv2_web_aclmodule to also take thecustom_response_bodiesargument, improved docs and extended testsISSUE TYPE
COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION
Also touched docs of
aws_waf_web_aclto make it easier to find the WAF v2 modules as I had trouble finding that at first.