New module for creating Cloudfront header policies… #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
module
|
Build succeeded (third-party-check pipeline).
|
|
still needs tests and perhaps a changelog fragment |
|
Build failed.
|
|
@stefanhorning no changelog needed for a new module (as it auto detects new modules on releases) but it does need adding to here I believe: |
|
Build failed.
|
marknet15
reviewed
Feb 7, 2022
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build green and ready to merge. |
|
@alinabuzachis Thanks for the review. I incorporated your suggestions now. |
|
Build failed.
|
|
upstream CI error... |
markuman
reviewed
Feb 22, 2022
|
recheck |
Co-authored-by: Markus Bergholz <[email protected]>
|
Ready to be merged now (from my side). |
marknet15
approved these changes
Mar 9, 2022
markuman
approved these changes
Mar 14, 2022
alinabuzachis
approved these changes
Mar 15, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #997 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
New module for creating Cloudfront header policies… .. used for response headers SUMMARY New Cloudfront module for CF response headers policies, see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/adding-response-headers.html This is still a relavily new feature, see https://aws.amazon.com/de/blogs/networking-and-content-delivery/amazon-cloudfront-introduces-response-headers-policies/ ISSUE TYPE New Module Pull Request COMPONENT NAME cloudfront_response_headers_policy.py Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Stefan Horning <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 87848dc)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
[PR #925/87848dcc backport][stable-3] New module for creating Cloudfront header policies… This is a backport of PR #925 as merged into main (87848dc). .. used for response headers SUMMARY New Cloudfront module for CF response headers policies, see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/adding-response-headers.html This is still a relavily new feature, see https://aws.amazon.com/de/blogs/networking-and-content-delivery/amazon-cloudfront-introduces-response-headers-policies/ ISSUE TYPE New Module Pull Request COMPONENT NAME cloudfront_response_headers_policy.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. used for response headers
SUMMARY
New Cloudfront module for CF response headers policies, see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/adding-response-headers.html
This is still a relavily new feature, see https://aws.amazon.com/de/blogs/networking-and-content-delivery/amazon-cloudfront-introduces-response-headers-policies/
ISSUE TYPE
COMPONENT NAME
cloudfront_response_headers_policy.py