[PR #881/cecc9e80 backport][stable-2] Fix cloudfront_distribution s3_origin_access_identity_enabled bug #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Fix cloudfront_distribution s3_origin_access_identity_enabled bug SUMMARY If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation. Fixes: #749 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The option mention is not valid for the API request: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit cecc9e8)
|
Build succeeded.
|
ansibullbot
added
bug
|
recheck |
|
Build failed (third-party-check pipeline) integration testing with
|
|
Build succeeded.
|
|
recheck |
|
Build succeeded (third-party-check pipeline).
|
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-2/cecc9e8087ce0bd1eacebdd19b4c45a17070eafa/pr-881
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #881 as merged into main (cecc9e8).
SUMMARY
If
s3_origin_access_identity_enabledis set toTruebut nos3_origin_configthen a default origin config is applied however it also picks ups3_origin_access_identity_enabledasS3OriginAccessIdentityEnabledand passes it to the API request which is not a valid option to be passed and then fails validation.Fixes: #749
ISSUE TYPE
COMPONENT NAME
cloudfront_distribution
ADDITIONAL INFORMATION
The option mention is not valid for the API request:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution