-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ssm connection: add support for SSM document #876
aws_ssm connection: add support for SSM document #876
Conversation
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please add a changelog fragment?
e259b9f
to
3705852
Compare
Thanks for your review! I added the changelog fragment and tried something for the integration tests |
Build succeeded.
|
@blinkseb It looks like the integration tests are currently disabled: I'm not sure of the history of the past issues and if they are resolved or not etc, but you can try running them locally to verify all is working as expected you would need to specify the
|
Build failed.
|
cc35729
to
c2792e4
Compare
Build failed.
|
74583b7
to
ad7c800
Compare
Build failed.
|
ad7c800
to
31af049
Compare
Build failed.
|
ok I'm progressing. I re-enabled the integration tests, like it was done in #763. I'm currently stuck with a permission error to create a new SSM document, so I opened a PR to add the necessary permissions here: mattclay/aws-terminator#192 |
This comment was marked as resolved.
This comment was marked as resolved.
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
hmmm
cc @gravesm |
Sure, would you mind submitting a PR for the missing policy to https://github.com/mattclay/aws-terminator? |
@blinkseb do you have some time to address the missing permission in a PR again? |
ef54543
to
46c881b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
46c881b
to
bf55002
Compare
bf55002
to
6381aef
Compare
c95c1ef
to
d343232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I'm reworking the tests a little so that we can test things still work without an SSM document
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1659 🤖 @patchback |
aws_ssm connection: add support for SSM document SUMMARY This PR adds support for SSM document to the SSM connection plugin. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.aws_ssm ADDITIONAL INFORMATION The new document parameters is directly forwarded to the SSM start_session method. Usage: - name: Install a Nginx Package vars: ansible_connection: aws_ssm ansible_aws_ssm_bucket_name: nameofthebucket ansible_aws_ssm_region: us-west-2 ansible_aws_ssm_document: nameofthecustomdocument tasks: - name: Install a Nginx Package yum: name: nginx state: present Reviewed-by: Alina Buzachis <None> Reviewed-by: Sébastien Brochet <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit a1c35a1)
thanks a lot! |
@blinkseb Thanks for taking the time to submit this PR, I'm sorry it took quite so long to get everything working. With integration tests now in place hopefully we can start to clear some of the backlog around the SSM connection plugin. |
aws_ssm connection: add support for SSM document SUMMARY This PR adds support for SSM document to the SSM connection plugin. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.aws_ssm ADDITIONAL INFORMATION The new document parameters is directly forwarded to the SSM start_session method. Usage: - name: Install a Nginx Package vars: ansible_connection: aws_ssm ansible_aws_ssm_bucket_name: nameofthebucket ansible_aws_ssm_region: us-west-2 ansible_aws_ssm_document: nameofthecustomdocument tasks: - name: Install a Nginx Package yum: name: nginx state: present Reviewed-by: Alina Buzachis <None> Reviewed-by: Sébastien Brochet <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit a1c35a1)
… for SSM document (#1659) [PR #876/a1c35a14 backport][stable-5] aws_ssm connection: add support for SSM document This is a backport of PR #876 as merged into main (a1c35a1). SUMMARY This PR adds support for SSM document to the SSM connection plugin. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.aws_ssm ADDITIONAL INFORMATION The new document parameters is directly forwarded to the SSM start_session method. Usage: - name: Install a Nginx Package vars: ansible_connection: aws_ssm ansible_aws_ssm_bucket_name: nameofthebucket ansible_aws_ssm_region: us-west-2 ansible_aws_ssm_document: nameofthecustomdocument tasks: - name: Install a Nginx Package yum: name: nginx state: present Reviewed-by: Mark Chappell <None>
Add integration tests for aws_resource_actions SUMMARY Add some minimal integration tests for the aws_resource_actions callback plugin. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/callback/aws_resource_actions.py ADDITIONAL INFORMATION Combined with ansible-collections#873 we've got a full set... Reviewed-by: Alina Buzachis <None>
SUMMARY
This PR adds support for SSM document to the SSM connection plugin.
ISSUE TYPE
COMPONENT NAME
community.aws.aws_ssm
ADDITIONAL INFORMATION
The new document parameters is directly forwarded to the SSM
start_session
method.Usage: