Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 commit #862

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Release 2.2.0 commit #862

merged 4 commits into from
Jan 20, 2022

Conversation

markuman
Copy link
Member

SUMMARY

Backport Release 2.2.0

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

everything

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Jan 20, 2022
@markuman markuman merged commit beaca66 into ansible-collections:stable-2 Jan 20, 2022
@markuman markuman deleted the release_2_2_0 branch January 20, 2022 13:51
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
aws_ec2 fix hostnames

SUMMARY

aws_ec2- fix hostnames bugs
Should fix ansible-collections#582 and ansible-collections#583

Fix returned hosts when

hostnames:
- tag:Tag1,Tag2


Fix returned hosts when

hostnames:
- tag:Tag1
- tag:Tag2


Fix returned hosts when

hostnames:
- tag:Tag1=Test1,Tag2=Test2

Given and EC2 instance with the following tags
tags:
  Tag1: Test1
  Tag2: Test2

Instead of only returning
"aws_ec2": {
    "hosts": [
        "Test1"
    ]
},
"tag_Name_instance_02": {
    "hosts": [
        "Test1"
    ]
},
"tag_Tag1_Test1": {
    "hosts": [
        "Test1"
    ]
},
"tag_Tag2_Test2": {
    "hosts": [
        "Test1"
    ]
}

It returns now
{
"_meta": {
   "hostvars": {
         "Test1": {
                "ami_launch_index": 0,
                "ansible_host": "10.210.0.101",
                   ...},
         "Test2": {
                 "ami_launch_index": 0,
                 "ansible_host": "10.210.0.101",
                   ...},
    },
    "all": {
        "children": [
            "aws_ec2",
            "tag_Name_instance_02",
            "tag_Tag1_Test1",
            "tag_Tag2_Test2",
            "ungrouped"
        ]
    },
    "aws_ec2": {
        "hosts": [
            "Test1",
            "Test2"
        ]
    },
    "tag_Name_instance_02": {
        "hosts": [
            "Test1",
            "Test2"
        ]
    },
    "tag_Tag1_Test1": {
        "hosts": [
            "Test1",
            "Test2"
        ]
    },
    "tag_Tag2_Test2": {
        "hosts": [
            "Test1",
            "Test2"
        ]
    }
}




 
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

aws_ec2
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants