Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing password_reset_required parameter #860

Merged
merged 6 commits into from
Jan 20, 2022
Merged

add missing password_reset_required parameter #860

merged 6 commits into from
Jan 20, 2022

Conversation

markuman
Copy link
Member

SUMMARY

password_reset_required parameter is missing in iam_user module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_user

ADDITIONAL INFORMATION

Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile.
Therefor the functionality can only be verified when the user is created, not when the user is udpated.

retval of update_login_profile is just

 0.0s create_or_update_user: 
      {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}}

Copy link
Contributor

@marknet15 marknet15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sorry I missed that before

@markuman
Copy link
Member Author

recheck

@markuman markuman changed the title [WIP] add missing password_reset_required parameter add missing password_reset_required parameter Jan 13, 2022
@markuman markuman added the backport-2 PR should be backported to the stable-2 branch label Jan 13, 2022
plugins/modules/iam_user.py Outdated Show resolved Hide resolved
@markuman markuman added mergeit Merge the PR (SoftwareFactory) and removed backport-2 PR should be backported to the stable-2 branch labels Jan 18, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c0b3e1b into ansible-collections:main Jan 20, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…lude SSLCertificateId (ansible-collections#860)

[WIP] elb_classic_lb: fix return value _format_listener method to include SSLCertificateId

SUMMARY

Fixes ansible-collections#686.
Current return value of _format_listener method does not include SSLCertificateId even if it is provided in the playbook, causing the failure as reported in above mentioned issue.
Sample return value:
{'InstancePort': 8080, 'InstanceProtocol': 'HTTP', 'LoadBalancerPort': 443, 'Protocol': 'HTTPS'}

This can be fixed by modifying the return value of _format_listener method to formatted_listener, which includes SSLCertificateId if provided in the playbook.
Sample return Value:
{'InstancePort': 8080, 'InstanceProtocol': 'HTTP', 'LoadBalancerPort': 443, 
'Protocol': 'HTTPS', 'SSLCertificateId': 'arn:aws:acm:us-east-1:1234...'}


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

elb_classic_lb

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
add missing password_reset_required parameter

SUMMARY
password_reset_required parameter is missing in iam_user module.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user
ADDITIONAL INFORMATION
Sadly, LoginProfile is only returned on create_login_profile and not on update_login_profile.
Therefor the functionality can only be verified when the user is created, not when the user is udpated.

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.create_login_profile
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.update_login_profile

retval of update_login_profile is just
 0.0s create_or_update_user:
      {'ResponseMetadata': {'HTTPHeaders': {'content-length': '216', 'content-type': 'text/xml', 'date': 'Wed, 12 Jan 2022 20:18:08 GMT', 'x-amzn-requestid': '11b6fde3-9f28-4265-8fac-88e3f5a238d3'}, 'HTTPStatusCode': 200, 'RequestId': '11b6fde3-9f28-4265-8fac-88e3f5a238d3', 'RetryAttempts': 0}}

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@c0b3e1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants