Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Modules #839

Merged
merged 11 commits into from
Jan 5, 2022
Merged

Remove deprecated Modules #839

merged 11 commits into from
Jan 5, 2022

Conversation

markuman
Copy link
Member

SUMMARY

Remove deprecated modules for 3.0.0 release

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.aws.iam
community.aws.rds

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman markuman changed the title [WIP] Remove deprecated Modules Remove deprecated Modules Dec 18, 2021
@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

alinabuzachis
alinabuzachis reviewed Dec 18, 2021
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we also need a changelog.

meta/runtime.yml Show resolved Hide resolved
@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@markuman
Copy link
Member Author

I guess we also need a changelog.

https://github.com/ansible-collections/community.aws/pull/839/files#diff-fabccf344e9d70fb2b98f5ac4a085fff495535d423736bdecf8a87d045860bdf

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman markuman requested a review from goneri December 20, 2021 05:41
@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Contributor

This is the task failing. cc @markuman

TASK [rds_instance : Ensure the resource doesn't exist] ************************
--
2312 | 2021-12-20 11:48:47.129918 \| fedora-35 \| task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_modify.yml:4
2313 | 2021-12-20 11:48:47.130598 \| fedora-35 \| The full traceback is:
2314 | 2021-12-20 11:48:47.130659 \| fedora-35 \| Traceback (most recent call last):
2315 | 2021-12-20 11:48:47.130671 \| fedora-35 \|   File "/tmp/ansible_rds_instance_payload_dfxy9pn8/ansible_rds_instance_payload.zip/ansible_collections/community/aws/plugins/modules/rds_instance.py", line 811, in get_instance
2316 | 2021-12-20 11:48:47.130686 \| fedora-35 \|   File "/home/zuul/venv/lib/python3.8/site-packages/botocore/client.py", line 357, in _api_call
2317 | 2021-12-20 11:48:47.130700 \| fedora-35 \|     return self._make_api_call(operation_name, kwargs)
2318 | 2021-12-20 11:48:47.130711 \| fedora-35 \|   File "/home/zuul/venv/lib/python3.8/site-packages/botocore/client.py", line 676, in _make_api_call
2319 | 2021-12-20 11:48:47.130722 \| fedora-35 \|     raise error_class(parsed_response, operation_name)
2320 | 2021-12-20 11:48:47.130746 \| fedora-35 \| botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the DescribeDBInstances operation: Invalid database identifier:  ansible-test-20797089-ansible-fedora-35-1vcpu-limestone-us-slc-modify
2321 | 2021-12-20 11:48:47.138619 \| fedora-35 \| fatal: [modify]: FAILED! => {
2322 | 2021-12-20 11:48:47.138826 \| fedora-35 \|     "boto3_version": "1.16.0",
2323 | 2021-12-20 11:48:47.138841 \| fedora-35 \|     "botocore_version": "1.19.0",
2324 | 2021-12-20 11:48:47.138853 \| fedora-35 \|     "changed": false,
2325 | 2021-12-20 11:48:47.138865 \| fedora-35 \|     "error": {
2326 | 2021-12-20 11:48:47.138875 \| fedora-35 \|         "code": "InvalidParameterValue",
2327 | 2021-12-20 11:48:47.138891 \| fedora-35 \|         "message": "Invalid database identifier:  ansible-test-20797089-ansible-fedora-35-1vcpu-limestone-us-slc-modify",
2328 | 2021-12-20 11:48:47.138904 \| fedora-35 \|         "type": "Sender"
2329 | 2021-12-20 11:48:47.138917 \| fedora-35 \|     },
2330 | 2021-12-20 11:48:47.138929 \| fedora-35 \|     "invocation": {
2331 | 2021-12-20 11:48:47.138940 \| fedora-35 \|         "module_args": {
2332 | 2021-12-20 11:48:47.138950 \| fedora-35 \|             "allocated_storage": null,
2333 | 2021-12-20 11:48:47.138963 \| fedora-35 \|             "allow_major_version_upgrade": null,
2334 | 2021-12-20 11:48:47.138974 \| fedora-35 \|             "apply_immediately": false,
2335 | 2021-12-20 11:48:47.138989 \| fedora-35 \|             "auto_minor_version_upgrade": null,
2336 | 2021-12-20 11:48:47.139001 \| fedora-35 \|             "availability_zone": null,
2337 | 2021-12-20 11:48:47.139012 \| fedora-35 \|             "aws_access_key": "ASIA6CCDWXDOH6YTV6W2",
2338 | 2021-12-20 11:48:47.139029 \| fedora-35 \|             "aws_ca_bundle": null,
2339 | 2021-12-20 11:48:47.139040 \| fedora-35 \|             "aws_config": null,
2340 | 2021-12-20 11:48:47.139053 \| fedora-35 \|             "aws_secret_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
2341 | 2021-12-20 11:48:47.139064 \| fedora-35 \|             "backup_retention_period": null,
2342 | 2021-12-20 11:48:47.139077 \| fedora-35 \|             "ca_certificate_identifier": null,
2343 | 2021-12-20 11:48:47.139087 \| fedora-35 \|             "character_set_name": null,
2344 | 2021-12-20 11:48:47.139098 \| fedora-35 \|             "copy_tags_to_snapshot": null,
2345 | 2021-12-20 11:48:47.139108 \| fedora-35 \|             "creation_source": null,
2346 | 2021-12-20 11:48:47.139121 \| fedora-35 \|             "db_cluster_identifier": null,
2347 | 2021-12-20 11:48:47.139131 \| fedora-35 \|             "db_instance_class": null,
2348 | 2021-12-20 11:48:47.139141 \| fedora-35 \|             "db_instance_identifier": "ansible-test-20797089-ansible-fedora-35-1vcpu-limestone-us-slc-modify",
2349 | 2021-12-20 11:48:47.139156 \| fedora-35 \|             "db_name": null,
2350 | 2021-12-20 11:48:47.139171 \| fedora-35 \|             "db_parameter_group_name": null,
2351 | 2021-12-20 11:48:47.139207 \| fedora-35 \|             "db_security_groups": null,
2352 | 2021-12-20 11:48:47.139219 \| fedora-35 \|             "db_snapshot_identifier": null,
2353 | 2021-12-20 11:48:47.139231 \| fedora-35 \|             "db_subnet_group_name": null,
2354 | 2021-12-20 11:48:47.139245 \| fedora-35 \|             "debug_botocore_endpoint_logs": true,
2355 | 2021-12-20 11:48:47.139255 \| fedora-35 \|             "domain": null,
2356 | 2021-12-20 11:48:47.139269 \| fedora-35 \|             "domain_iam_role_name": null,
2357 | 2021-12-20 11:48:47.139325 \| fedora-35 \|             "ec2_url": null,
2358 | 2021-12-20 11:48:47.139342 \| fedora-35 \|             "enable_cloudwatch_logs_exports": null,
2359 | 2021-12-20 11:48:47.139354 \| fedora-35 \|             "enable_iam_database_authentication": null,
2360 | 2021-12-20 11:48:47.139366 \| fedora-35 \|             "enable_performance_insights": null,
2361 | 2021-12-20 11:48:47.139378 \| fedora-35 \|             "engine": null,
2362 | 2021-12-20 11:48:47.139388 \| fedora-35 \|             "engine_version": null,
2363 | 2021-12-20 11:48:47.139402 \| fedora-35 \|             "final_db_snapshot_identifier": null,
2364 | 2021-12-20 11:48:47.139411 \| fedora-35 \|             "force_failover": null,
2365 | 2021-12-20 11:48:47.139464 \| fedora-35 \|             "force_update_password": false,
2366 | 2021-12-20 11:48:47.139491 \| fedora-35 \|             "id": "ansible-test-20797089-ansible-fedora-35-1vcpu-limestone-us-slc-modify",
2367 | 2021-12-20 11:48:47.139509 \| fedora-35 \|             "iops": null,
2368 | 2021-12-20 11:48:47.139528 \| fedora-35 \|             "kms_key_id": null,
2369 | 2021-12-20 11:48:47.139541 \| fedora-35 \|             "license_model": null,
2370 | 2021-12-20 11:48:47.139553 \| fedora-35 \|             "master_user_password": null,
2371 | 2021-12-20 11:48:47.139565 \| fedora-35 \|             "master_username": null,
2372 | 2021-12-20 11:48:47.139575 \| fedora-35 \|             "max_allocated_storage": null,
2373 | 2021-12-20 11:48:47.139586 \| fedora-35 \|             "monitoring_interval": null,
2374 | 2021-12-20 11:48:47.139597 \| fedora-35 \|             "monitoring_role_arn": null,
2375 | 2021-12-20 11:48:47.139608 \| fedora-35 \|             "multi_az": null,
2376 | 2021-12-20 11:48:47.139619 \| fedora-35 \|             "new_db_instance_identifier": null,
2377 | 2021-12-20 11:48:47.139629 \| fedora-35 \|             "option_group_name": null,
2378 | 2021-12-20 11:48:47.139641 \| fedora-35 \|             "performance_insights_kms_key_id": null,
2379 | 2021-12-20 11:48:47.139653 \| fedora-35 \|             "performance_insights_retention_period": null,
2380 | 2021-12-20 11:48:47.139665 \| fedora-35 \|             "port": null,
2381 | 2021-12-20 11:48:47.139677 \| fedora-35 \|             "preferred_backup_window": null,
2382 | 2021-12-20 11:48:47.139688 \| fedora-35 \|             "preferred_maintenance_window": null,
2383 | 2021-12-20 11:48:47.139698 \| fedora-35 \|             "processor_features": null,
2384 | 2021-12-20 11:48:47.139712 \| fedora-35 \|             "profile": null,
2385 | 2021-12-20 11:48:47.139734 \| fedora-35 \|             "promotion_tier": null,
2386 | 2021-12-20 11:48:47.139745 \| fedora-35 \|             "publicly_accessible": null,
2387 | 2021-12-20 11:48:47.139755 \| fedora-35 \|             "purge_cloudwatch_logs_exports": true,
2388 | 2021-12-20 11:48:47.139766 \| fedora-35 \|             "purge_security_groups": true,
2389 | 2021-12-20 11:48:47.139776 \| fedora-35 \|             "purge_tags": true,
2390 | 2021-12-20 11:48:47.139788 \| fedora-35 \|             "read_replica": null,
2391 | 2021-12-20 11:48:47.139798 \| fedora-35 \|             "region": "us-east-1",
2392 | 2021-12-20 11:48:47.139809 \| fedora-35 \|             "restore_time": null,
2393 | 2021-12-20 11:48:47.139820 \| fedora-35 \|             "s3_bucket_name": null,
2394 | 2021-12-20 11:48:47.139831 \| fedora-35 \|             "s3_ingestion_role_arn": null,
2395 | 2021-12-20 11:48:47.139840 \| fedora-35 \|             "s3_prefix": null,
2396 | 2021-12-20 11:48:47.139850 \| fedora-35 \|             "security_token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
2397 | 2021-12-20 11:48:47.139866 \| fedora-35 \|             "skip_final_snapshot": true,
2398 | 2021-12-20 11:48:47.139878 \| fedora-35 \|             "snapshot_identifier": null,
2399 | 2021-12-20 11:48:47.139890 \| fedora-35 \|             "source_db_instance_identifier": null,
2400 | 2021-12-20 11:48:47.139901 \| fedora-35 \|             "source_engine": null,
2401 | 2021-12-20 11:48:47.139910 \| fedora-35 \|             "source_engine_version": null,
2402 | 2021-12-20 11:48:47.139922 \| fedora-35 \|             "source_region": null,
2403 | 2021-12-20 11:48:47.139934 \| fedora-35 \|             "state": "absent",
2404 | 2021-12-20 11:48:47.139945 \| fedora-35 \|             "storage_encrypted": null,
2405 | 2021-12-20 11:48:47.139955 \| fedora-35 \|             "storage_type": null,
2406 | 2021-12-20 11:48:47.139965 \| fedora-35 \|             "tags": null,
2407 | 2021-12-20 11:48:47.139975 \| fedora-35 \|             "tde_credential_arn": null,
2408 | 2021-12-20 11:48:47.139985 \| fedora-35 \|             "tde_credential_password": null,
2409 | 2021-12-20 11:48:47.139996 \| fedora-35 \|             "timezone": null,
2410 | 2021-12-20 11:48:47.140007 \| fedora-35 \|             "use_latest_restorable_time": null,
2411 | 2021-12-20 11:48:47.140037 \| fedora-35 \|             "validate_certs": true,
2412 | 2021-12-20 11:48:47.140052 \| fedora-35 \|             "vpc_security_group_ids": null,
2413 | 2021-12-20 11:48:47.140061 \| fedora-35 \|             "wait": true
2414 | 2021-12-20 11:48:47.140074 \| fedora-35 \|         }
2415 | 2021-12-20 11:48:47.140085 \| fedora-35 \|     },
2416 | 2021-12-20 11:48:47.140132 \| fedora-35 \|     "msg": "Failed to describe DB instances: An error occurred (InvalidParameterValue) when calling the DescribeDBInstances operation: Invalid database identifier:  ansible-test-20797089-ansible-fedora-35-1vcpu-limestone-us-slc-modify",
2417 | 2021-12-20 11:48:47.140230 \| fedora-35 \|     "resource_actions": [
2418 | 2021-12-20 11:48:47.140243 \| fedora-35 \|         "rds:DescribeDBInstances"
2419 | 2021-12-20 11:48:47.140253 \| fedora-35 \|     ],
2420 | 2021-12-20 11:48:47.140262 \| fedora-35 \|     "response_metadata": {
2421 | 2021-12-20 11:48:47.140272 \| fedora-35 \|         "http_headers": {
2422 | 2021-12-20 11:48:47.140324 \| fedora-35 \|             "connection": "close",
2423 | 2021-12-20 11:48:47.140340 \| fedora-35 \|             "content-length": "351",
2424 | 2021-12-20 11:48:47.140374 \| fedora-35 \|             "content-type": "text/xml",
2425 | 2021-12-20 11:48:47.140397 \| fedora-35 \|             "date": "Mon, 20 Dec 2021 11:48:43 GMT",
2426 | 2021-12-20 11:48:47.140409 \| fedora-35 \|             "x-amzn-requestid": "02a7506f-2c7d-4b2e-bc96-a62376346797"
2427 | 2021-12-20 11:48:47.140419 \| fedora-35 \|         },
2428 | 2021-12-20 11:48:47.140428 \| fedora-35 \|         "http_status_code": 400,
2429 | 2021-12-20 11:48:47.140438 \| fedora-35 \|         "request_id": "02a7506f-2c7d-4b2e-bc96-a62376346797",
2430 | 2021-12-20 11:48:47.140448 \| fedora-35 \|         "retry_attempts": 0
2431 | 2021-12-20 11:48:47.140459 \| fedora-35 \|     }
2432 | 2021-12-20 11:48:47.140470 \| fedora-35 \| }

@markuman
Copy link
Member Author

markuman commented Dec 20, 2021 •
edited by alinabuzachis
Loading

@alinabuzachis hmm is community.aws.rds_instance somewhere related with community.aws.rds?

An error occurred (InvalidParameterValue) when calling the DescribeDBInstances operation: Invalid database identifier

@markuman I don't think so.

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

markuman commented Jan 1, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

markuman commented Jan 3, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jillr jillr added the gate label Jan 5, 2022
ansible-zuul[bot]
ansible-zuul bot approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markuman markuman added gate and removed gate labels Jan 5, 2022
@ansible-zuul ansible-zuul bot merged commit 2096b7f into ansible-collections:main Jan 5, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@markuman @goneri
Remove deprecated Modules (ansible-collections#839)
bf66d00 
Remove deprecated Modules

SUMMARY
Remove deprecated modules for 3.0.0 release
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
community.aws.iam
community.aws.rds

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@2096b7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

@tremble tremble Awaiting requested review from tremble

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markuman @alinabuzachis @jillr