Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix short EKS cluster names #818

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Fix short EKS cluster names #818

merged 6 commits into from
Jan 5, 2022

Conversation

markuman
Copy link
Member

@markuman markuman commented Dec 2, 2021

SUMMARY

Fixes #817

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_eks

ADDITIONAL INFORMATION

@markuman markuman added the backport-2 PR should be backported to the stable-2 branch label Dec 2, 2021
@markuman markuman changed the title [WIP] Fix short EKS cluster names Fix short EKS cluster names Dec 2, 2021
@markuman markuman requested review from jillr and tremble December 2, 2021 20:11
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman markuman added the gate label Jan 5, 2022
ansible-zuul[bot]
ansible-zuul bot approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit bd48c16 into ansible-collections:main Jan 5, 2022
@patchback
Copy link

patchback bot commented Jan 5, 2022 •
edited
Loading

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/bd48c1646d1ef86c1d5493e5af2d836c946b4c88/pr-818

Backported as #847

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 5, 2022
@markuman @patchback
Fix short EKS cluster names (#818)
74649d4 
Fix short EKS cluster names

SUMMARY
Fixes #817
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_eks
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
(cherry picked from commit bd48c16)
@patchback patchback bot mentioned this pull request Jan 5, 2022
Merged
markuman added a commit that referenced this pull request Jan 13, 2022
@markuman
Merge pull request #847 from ansible-collections/patchback/backports/…
0450a79 
…stable-2/bd48c1646d1ef86c1d5493e5af2d836c946b4c88/pr-818

[PR #818/bd48c164 backport][stable-2] Fix short EKS cluster names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr Awaiting requested review from jillr

@tremble tremble Awaiting requested review from tremble

Assignees
No one assigned
Labels
backport-2 PR should be backported to the stable-2 branch
Projects
None yet
Milestone
No milestone
2 participants
@markuman @alinabuzachis