Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda_info - use a paginator and AWSRetry #777

Merged
merged 3 commits into from
Oct 23, 2021
Merged

lambda_info - use a paginator and AWSRetry #777

merged 3 commits into from
Oct 23, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 22, 2021

SUMMARY

Add paginator and AWSRetry to lambda_info. It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lambda_info

ADDITIONAL INFORMATION

@tremble tremble requested a review from markuman October 22, 2021 21:58
@ansibullbot
Copy link

cc @jillr @markuman @pjodouin @s-hertel @steynovich @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 22, 2021
@tremble tremble requested a review from alinabuzachis October 23, 2021 06:17
markuman
markuman approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble added the gate label Oct 23, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 07e2522 into ansible-collections:main Oct 23, 2021
@tremble tremble deleted the lambda_info/paginator branch November 26, 2021 12:44
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
lambda_info - use a paginator and AWSRetry (ansible-collections#777)
0d2b35f 
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@07e2522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @markuman