Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elb_instance - boto3 migration #773

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 21, 2021

SUMMARY

Migrate elb_instance to boto3

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_instance

ADDITIONAL INFORMATION

Depends-On: ansible/ansible-zuul-jobs#1200

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Oct 21, 2021
@tremble tremble force-pushed the boto3/elb_instance branch from f62ff8b to 2c007d2 Compare October 21, 2021 14:29
@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels Oct 21, 2021
@tremble tremble changed the title [WIP] elb_instance - boto3 migration elb_instance - boto3 migration Oct 21, 2021
@tremble tremble removed the WIP Work in progress label Oct 21, 2021
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments, thanks @tremble!

@tremble tremble requested a review from jillr October 24, 2021 18:38
@tremble tremble force-pushed the boto3/elb_instance branch 2 times, most recently from e75b0c6 to 0289486 Compare October 25, 2021 12:33
@tremble tremble force-pushed the boto3/elb_instance branch from 48d2393 to 0ad0cf4 Compare October 26, 2021 05:37
@tremble tremble requested a review from jillr October 26, 2021 05:49
@tremble tremble force-pushed the boto3/elb_instance branch from 0ad0cf4 to 3871049 Compare October 26, 2021 11:19
@tremble tremble added the gate label Oct 27, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 96f1518 into ansible-collections:main Oct 27, 2021
@tremble tremble deleted the boto3/elb_instance branch November 26, 2021 12:44
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 30, 2022
elb_instance - remove ec2_elbs fact

SUMMARY
The ec2_elbs fact was deprecated when we migrated to boto3, remove it.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_instance
ADDITIONAL INFORMATION
See also: #773

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants