Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elb_instance - initial integration tests #768

Merged
merged 3 commits into from
Oct 20, 2021
Merged

elb_instance - initial integration tests #768

merged 3 commits into from
Oct 20, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 17, 2021 •
edited
Loading

SUMMARY

Rewrite elb_instance (ec2_elb) for boto3

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_instance

ADDITIONAL INFORMATION

fixes: #384

@ansibullbot
Copy link

cc @jarv @jillr @markuman @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 17, 2021
@tremble tremble force-pushed the boto3/elb_instance branch from 30a06f2 to 2046eee Compare October 18, 2021 06:16
@tremble tremble mentioned this pull request Oct 19, 2021
Merged
@tremble tremble force-pushed the boto3/elb_instance branch from 2046eee to 11e80a8 Compare October 19, 2021 13:18
@goneri
Copy link
Member

goneri commented Oct 19, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator

jillr commented Oct 19, 2021

recheck

@jillr
Copy link
Collaborator

jillr commented Oct 19, 2021

Policies has been deployed

@tremble tremble force-pushed the boto3/elb_instance branch from 11e80a8 to eac68b2 Compare October 19, 2021 18:50
@tremble tremble changed the title [WIP] elb_instance - boto3 rewrite elb_instance - initial integration tests Oct 20, 2021
@tremble tremble requested a review from alinabuzachis October 20, 2021 06:41
@tremble tremble removed the WIP Work in progress label Oct 20, 2021
@tremble tremble requested a review from markuman October 20, 2021 11:04
markuman
markuman approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble added the gate label Oct 20, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 4e1c5db into ansible-collections:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors removing instances from classic ELB with ec2_elb
6 participants
@tremble @ansibullbot @goneri @jillr @markuman @alinabuzachis