Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling route53 health checks #756

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 12, 2021

SUMMARY

Add support for disabling route53 health checks

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

route53_health_check

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 12, 2021
@tremble tremble added the gate label Oct 13, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit cf4a95a into ansible-collections:main Oct 13, 2021
@tremble tremble deleted the route53/disable-healthcheck branch November 26, 2021 12:44
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…stance and state is set to rebooted (ansible-collections#756)

ec2_instance - raise an error when missing permission to stop instance

SUMMARY


Fixes ansible-collections#671
When missing permission to stop an instance, the module quietly exists instead of raising an error.
This PR fixes that.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_instance

Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants