Rds enhanced monitoring bug fix #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
ansibullbot
added
bug
|
recheck |
2 similar comments
|
recheck |
|
recheck |
marknet15
force-pushed
the
rds-enhanced-monitoring
branch
from
e056ea8 to
b1e419d
Compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
|
recheck |
|
@jillr @gundalow the recheck doesn't seem to be triggering Zuul for some reason now! I'm a little unsure on what to try next, this was a clean branch with cherry picked commits as I messed up a rebase on the old branch. I also tried creating a brand new commit on a new branch and it also doesn't seem to want to trigger :( |
|
@marknet15 The labels do not affect Zuul and I don't see anything that looks wrong here. Unfortunately all of our Zuul experts are in Canada and on public holiday today, tomorrow we should be able to figure out more. |
|
recheck |
|
recheck |
2 similar comments
|
recheck |
|
recheck |
|
recheck |
marknet15
force-pushed
the
rds-enhanced-monitoring
branch
from
e55d3a9 to
861463e
Compare
|
@alinabuzachis @jillr @tremble this is finally ready for a review :) the tests now run and complete within the 1hr session |
marknet15
force-pushed
the
rds-enhanced-monitoring
branch
from
861463e to
7e2cd42
Compare
test update correct test var Enable tests Update tests/integration/targets/rds_instance/aliases Co-authored-by: Mark Chappell <[email protected]> try leaving out the iam deletion for enhanced monitoring move IAM creation to earlier on The tests are exceeding a 1hr session limit - Condense tests where possible - Remove irrelevant snapshot tests - Up concurrency to 6 PR feedback disable wait on final delete further adjust update changelog speed up tests speed up tests test failure fixes fix final broken test split tagging out test adjustments final test failure hitting max length modify tests adjust version bump fix
marknet15
force-pushed
the
rds-enhanced-monitoring
branch
from
7e2cd42 to
e839bc1
Compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
tremble
reviewed
Oct 19, 2021
tremble
approved these changes
Oct 22, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Rds enhanced monitoring bug fix SUMMARY (a copy of ansible-collections#712 as I messed up my branch by accident) This is a fix for an issue when an RDS instance already exists and you wish to enable enhanced monitoring, for the full details see the linked old reported issue: ansible/ansible#51772 But in summary currently if you enable enhanced monitoring on an RDS instance that already exists where it isn't already enabled then the following is returned: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: KeyError: 'MonitoringRoleArn' fatal: [localhost_eu-west-1-pdv-qa-1 -> 127.0.0.1]: FAILED! => changed=false module_stderr: |- Traceback (most recent call last): File "master:/opt/mitogen/mitogen-0.2.9/ansible_mitogen/runner.py", line 975, in _run self._run_code(code, mod) File "master:/opt/mitogen/mitogen-0.2.9/ansible_mitogen/runner.py", line 939, in _run_code exec(code, vars(mod)) File "master:/tmp/build/4bef5c86/framework/library/cloud/aws/rds_instance.py", line 1245, in <module> File "master:/tmp/build/4bef5c86/framework/library/cloud/aws/rds_instance.py", line 1210, in main File "master:/tmp/build/4bef5c86/framework/library/cloud/aws/rds_instance.py", line 855, in get_parameters File "master:/tmp/build/4bef5c86/framework/library/cloud/aws/rds_instance.py", line 885, in get_options_with_changing_values File "master:/tmp/build/4bef5c86/framework/library/cloud/aws/rds_instance.py", line 983, in get_changing_options_with_consistent_keys KeyError: 'MonitoringRoleArn' module_stdout: '' msg: |- MODULE FAILURE See stdout/stderr for the exact error Originally-Depends-On: mattclay/aws-terminator#164 Other changes A load of issues have surfaced in the integration tests due to how slow RDS is to create / modify etc. I've condensed down the tests where possible reducing the number of inventory jobs to 6 and bumped serial to 6 so that hopefully all tests can run at once and finish within the 1 hr AWS session duration. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@8fe00cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
(a copy of #712 as I messed up my branch by accident)
This is a fix for an issue when an RDS instance already exists and you wish to enable enhanced monitoring, for the full details see the linked old reported issue:
ansible/ansible#51772
But in summary currently if you enable enhanced monitoring on an RDS instance that already exists where it isn't already enabled then the following is returned:
Originally-Depends-On: mattclay/aws-terminator#164
Other changes
A load of issues have surfaced in the integration tests due to how slow RDS is to create / modify etc. I've condensed down the tests where possible reducing the number of inventory jobs to
6and bumpedserialto6so that hopefully all tests can run at once and finish within the1hr AWS session duration.ISSUE TYPE
COMPONENT NAME
rds_instance