Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53_health_check integration tests #746

Merged
merged 4 commits into from
Oct 8, 2021
Merged

route53_health_check integration tests #746

merged 4 commits into from
Oct 8, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 8, 2021

SUMMARY

For some reason the previous PR wasn't triggering CI properly

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

route53_health_check

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @wimnat @zimbatm
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 8, 2021
@tremble tremble requested a review from alinabuzachis October 8, 2021 08:52
@tremble tremble mentioned this pull request Oct 8, 2021
Merged
3 tasks
@alinabuzachis
Copy link
Contributor

recheck

1 similar comment
@tremble
Copy link
Contributor Author

tremble commented Oct 8, 2021

recheck

@tremble tremble requested a review from markuman October 8, 2021 19:06
markuman
markuman approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble added the gate label Oct 8, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit b67e093 into ansible-collections:main Oct 8, 2021
ansible-zuul bot added a commit that referenced this pull request Oct 11, 2021
@ansible-zuul
Merge pull request #734 from tremble/boto3/route53_health_check
ff16412 
route53_health_check - boto3 migration 

SUMMARY
route53_health_check migration to boto3
Depends-On: #746
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION
Todo:

 changelog
 docs for new return values
 tests for return values

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
@tremble tremble deleted the tests/route53_health_check branch November 26, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @ansibullbot @alinabuzachis @markuman