Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modules for RDS clusters management #687

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Aug 12, 2021

SUMMARY

Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info)

Took over from: #262

Depends-On: ansible-collections/amazon.aws#553

Closes #849
Should also close #191

ISSUE TYPE
  • New Module Pull Request

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Aug 12, 2021
ansible-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Aug 16, 2021
Add waiters for RDS cluster

SUMMARY

Add waiters for RDS cluster (cluster_available and cluster_deleted) required by ansible-collections/community.aws#687

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

waiters.py
Depends-On: ansible/ansible-zuul-jobs#1062

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
@tremble
Copy link
Contributor

tremble commented Oct 15, 2021

@alinabuzachis There was a ping on IRC asking after this module, what's the current status of it?

@tremble
Copy link
Contributor

tremble commented Oct 15, 2021

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

1 similar comment
@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

s-hertel and others added 8 commits January 5, 2022 11:44
Signed-off-by: Alina Buzachis <[email protected]>
@markuman
Copy link
Member

markuman commented Apr 5, 2022

@alinabuzachis

allocated_storage parameter must be also removed from the integration tests...

TASK [rds_cluster : Create a source DB cluster] ********************************

    "msg": "Unsupported parameters for (rds_cluster) module: allocated_storage. Supported parameters include: master_user_password (password), copy_tags_to_snapshot, purge_cloudwatch_logs_exports, source_db_cluster_identifier, db_cluster_identifier (cluster_id, cluster_name, id), storage_encrypted, use_latest_restorable_time, purge_tags, region (aws_region, ec2_region), force_backtrack, character_set_name, snapshot_identifier, enable_global_write_forwarding, enable_iam_database_authentication, master_username (username), replication_source_identifier (replication_src_id), source_engine_version, tags, force_update_password, option_group_name, purge_security_groups, aws_config, source_engine, restore_type, engine, engine_version, source_region, preferred_backup_window (backup_window), db_subnet_group_name, db_cluster_parameter_group_name, aws_secret_key (ec2_secret_key, secret_key), s3_ingestion_role_arn, domain, aws_ca_bundle, validate_certs, restore_to_time, s3_prefix, ec2_url (aws_endpoint_url, endpoint_url), availability_zones (az, zones), backtrack_to, apply_immediately, enable_http_endpoint, vpc_security_group_ids, state, s3_bucket_name, global_cluster_identifier, port, preferred_maintenance_window (maintenance_window), skip_final_snapshot, kms_key_id, new_db_cluster_identifier (new_cluster_id, new_cluster_name, new_id), backtrack_window, enable_cloudwatch_logs_exports, aws_access_key (access_key, ec2_access_key), backup_retention_period, domain_iam_role_name, profile (aws_profile), promote, role_arn, security_token (access_token, aws_security_token, aws_session_token, session_token), debug_botocore_endpoint_logs, deletion_protection, use_earliest_time_on_point_in_time_unavailable, wait, database_name (db_name), final_snapshot_identifier, creation_source."

@alinabuzachis
Copy link
Contributor Author

@alinabuzachis

allocated_storage parameter must be also removed from the integration tests...

TASK [rds_cluster : Create a source DB cluster] ********************************

    "msg": "Unsupported parameters for (rds_cluster) module: allocated_storage. Supported parameters include: master_user_password (password), copy_tags_to_snapshot, purge_cloudwatch_logs_exports, source_db_cluster_identifier, db_cluster_identifier (cluster_id, cluster_name, id), storage_encrypted, use_latest_restorable_time, purge_tags, region (aws_region, ec2_region), force_backtrack, character_set_name, snapshot_identifier, enable_global_write_forwarding, enable_iam_database_authentication, master_username (username), replication_source_identifier (replication_src_id), source_engine_version, tags, force_update_password, option_group_name, purge_security_groups, aws_config, source_engine, restore_type, engine, engine_version, source_region, preferred_backup_window (backup_window), db_subnet_group_name, db_cluster_parameter_group_name, aws_secret_key (ec2_secret_key, secret_key), s3_ingestion_role_arn, domain, aws_ca_bundle, validate_certs, restore_to_time, s3_prefix, ec2_url (aws_endpoint_url, endpoint_url), availability_zones (az, zones), backtrack_to, apply_immediately, enable_http_endpoint, vpc_security_group_ids, state, s3_bucket_name, global_cluster_identifier, port, preferred_maintenance_window (maintenance_window), skip_final_snapshot, kms_key_id, new_db_cluster_identifier (new_cluster_id, new_cluster_name, new_id), backtrack_window, enable_cloudwatch_logs_exports, aws_access_key (access_key, ec2_access_key), backup_retention_period, domain_iam_role_name, profile (aws_profile), promote, role_arn, security_token (access_token, aws_security_token, aws_session_token, session_token), debug_botocore_endpoint_logs, deletion_protection, use_earliest_time_on_point_in_time_unavailable, wait, database_name (db_name), final_snapshot_identifier, creation_source."

You right! 😅 Thank you.

@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label Apr 5, 2022
@markuman
Copy link
Member

markuman commented Apr 5, 2022

Access Denied

    "message": "User: arn:aws:sts::966509639900:assumed-role/ansible-core-ci-test-prod/prod=remote=zuul-cloud is not authorized to perform: rds:RestoreDBClusterToPointInTime on resource: arn:aws:rds:us-east-1:966509639900:cluster:ansible-test-restored2ce700a4272-point-in-time because no identity-based policy allows the rds:RestoreDBClusterToPointInTime action",

I think you must turn an extra round with the terminator repo now.

@alinabuzachis
Copy link
Contributor Author

recheck

Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Apr 5, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3661b1c into ansible-collections:main Apr 5, 2022
@patchback
Copy link

patchback bot commented Apr 5, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/3661b1ca39b36b46afbb0669db3c755deab496cb/pr-687

Backported as #1050

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 5, 2022
New modules for RDS clusters management

SUMMARY

Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info)
Took over from: #262
Depends-On: ansible-collections/amazon.aws#553
Closes #849
Should also close #191

ISSUE TYPE

New Module Pull Request

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 3661b1c)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 6, 2022
[PR #687/3661b1ca backport][stable-3] New modules for RDS clusters management

This is a backport of PR #687 as merged into main (3661b1c).
SUMMARY

Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info)
Took over from: #262
Depends-On: ansible-collections/amazon.aws#553
Closes #849
Should also close #191

ISSUE TYPE


New Module Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 14, 2022
…788)

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting

SUMMARY

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting
Requires rds_cluster to be merged first #687
Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212
Requires also mattclay/aws-terminator#184

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

rds_cluster_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>
patchback bot pushed a commit that referenced this pull request Jun 14, 2022
…788)

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting

SUMMARY

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting
Requires rds_cluster to be merged first #687
Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212
Requires also mattclay/aws-terminator#184

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_cluster_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 5e7acbd)
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
New modules for RDS clusters management

SUMMARY

Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info)
Took over from: ansible-collections#262
Depends-On: ansible-collections/amazon.aws#553
Closes ansible-collections#849
Should also close ansible-collections#191

ISSUE TYPE

New Module Pull Request

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@3661b1c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…nsible-collections#788)

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting

SUMMARY

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting
Requires rds_cluster to be merged first ansible-collections#687
Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212
Requires also mattclay/aws-terminator#184

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_cluster_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@5e7acbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use community.aws.rds_instance module to create Aurora cluster Support AWS RDS serverless
7 participants