Update remaining _info modules so that they run in check_mode #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuman
approved these changes
Jul 28, 2021
ansibullbot
added
community_review
feature
tremble
force-pushed
the
cleanup/check_mode
branch
from
c153c8d to
0ff4741
Compare
tremble
force-pushed
the
cleanup/check_mode
branch
from
886f434 to
8081e69
Compare
felixfontein
approved these changes
Jul 28, 2021
markuman
approved these changes
Jul 28, 2021
|
recheck |
5 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
recheck |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update remaining _info modules so that they run in check_mode
https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions
https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions
fixes: #659
ISSUE TYPE
COMPONENT NAME
aws_sgw_info
ec2_asg_info
ec2_lc_info
iam_mfa_device_info
iam_server_certificate_info
wafv2_resources_info
wafv2_web_acl_info
ADDITIONAL INFORMATION
cc: @felixfontein
It would be good to get this in before the upcoming sanity check: ansible/ansible#75324
amazon.aws/pull/405
Depends-on: ansible/ansible-zuul-jobs#1014