Migrate ec2_vpc_nat_gateway* modules and tests #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
docs
integration
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
from
ac8f4f3 to
040fd94
Compare
|
recheck |
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
2 times, most recently
from
cab3aab to
b4ccb16
Compare
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
6 times, most recently
from
68c9ca2 to
2c8087c
Compare
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
from
2c8087c to
79ffb9c
Compare
|
recheck |
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
from
79ffb9c to
3d2fc7c
Compare
|
recheck |
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
from
3d2fc7c to
2be1d8e
Compare
alinabuzachis
changed the title
tremble
requested changes
Aug 25, 2021
alinabuzachis
force-pushed
the
promote_ec2_vpc_nat_gateway
branch
from
2be1d8e to
971c572
Compare
|
recheck |
tremble
approved these changes
Aug 27, 2021
|
ansible-collections/amazon.aws#410 has merged. gating this one. |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Update ec2_instance.py SUMMARY vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error-> TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] ********************************************************************************************************** fatal: [localhost]: FAILED! => changed=false msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance changing to match other examples ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION n/a, only see one bad example here Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible-collections/amazon.aws#410
Remove ec2_vpc_nat_gateway* modules and tests
These modules have been migrated to
amazon.awsUpdate runtime.yml with redirects to that collection
Update ignore files