Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup integration tests post-Zuul migration #563

Merged
merged 16 commits into from
Jul 2, 2021
Merged

Cleanup integration tests post-Zuul migration #563

merged 16 commits into from
Jul 2, 2021

Conversation

jillr
Copy link
Collaborator

@jillr jillr commented Apr 30, 2021 •
edited by tremble
Loading

SUMMARY

This collection has been operating on Zuul CI for some weeks now.

  • Remove shippable references
  • Use shorter unique_ids were resource_prefixes now exceed AWS resource length limits (zuul hostnames are longer than shippable was)
  • Cleanup for CI bugs surfaced in the course of this PR
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

shippable.yml
tests/
README.md

NOT-Depends-On: ansible/ansible-zuul-jobs#978

@jillr
Copy link
Collaborator Author

jillr commented Apr 30, 2021

There's a number of tests that build a shortened unique_id from the resource_prefix based on what these were with shippable. eg; tests/integration/targets/sns_topic/defaults/main.yml
Zuul does not append a test-run unique digit at the end of the prefix like shippable did. We're not currently doing any parallel tests, so we could get by with a single set of digits from these tests, but curious what you think @tremble before I make changes.

@jillr jillr force-pushed the remove_shippable branch from 96358b0 to 30bd11d Compare April 30, 2021 23:05
@tremble
Copy link
Contributor

tremble commented May 15, 2021

@jillr someone's already started just md5sum-ing the resource_prefix I'm good with that approach.

@jillr jillr changed the title [WIP] Remove shippable references from repo Remove shippable references from repo May 20, 2021
tremble
tremble approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble
Copy link
Contributor

tremble commented May 21, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator Author

jillr commented May 25, 2021

recheck

@ansibullbot
Copy link

@jillr This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels May 25, 2021
@jillr jillr force-pushed the remove_shippable branch from b6185d2 to b1e5fd0 Compare June 3, 2021 17:54
@jillr
Copy link
Collaborator Author

jillr commented Jun 7, 2021

the only changes since the last review are from cleaning up a merge conflict, and then fixing a line I messed up in that conflict resolution, will gate once CI passes on the existing review so it doesn't go into conflict again.

@jillr jillr force-pushed the remove_shippable branch from 335426c to ccdfc93 Compare June 7, 2021 17:57
@jillr
Copy link
Collaborator Author

jillr commented Jun 7, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator Author

jillr commented Jun 7, 2021

recheck

@jillr jillr force-pushed the remove_shippable branch 3 times, most recently from e5eb9eb to 6fc4a63 Compare June 8, 2021 22:14
@jillr
Copy link
Collaborator Author

jillr commented Jun 8, 2021

Working my way through resource names that are length exceeded with the zuul resource_prefix length; since we don't have ci_complete jobs anymore this is effectively the first time we've run into most of these. It's overloading this PR a bit but my priority right now is making CI green while we have a change to test that actually touches every target.

@goneri
Copy link
Member

goneri commented Jun 9, 2021

Since this PR will likely trigger the whole test-suite, I would suggest to split it up in 3 or 4 PR. This way it will be easier to merge the smaller PR one by one.

@jillr
Copy link
Collaborator Author

jillr commented Jun 11, 2021

recheck

@jillr jillr force-pushed the remove_shippable branch 2 times, most recently from 9f4721e to 8893fff Compare June 11, 2021 18:49
@jillr jillr added the gate label Jun 11, 2021
@goneri
Copy link
Member

goneri commented Jun 11, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator Author

jillr commented Jun 11, 2021

recheck

@ansible-zuul ansible-zuul bot removed the gate label Jun 14, 2021
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jul 1, 2021
@jillr jillr removed gate needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 1, 2021
@jillr
Copy link
Collaborator Author

jillr commented Jul 1, 2021

gate hit some of the usual API lag issues, retrying

@jillr jillr added the gate label Jul 1, 2021
@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 1, 2021
@goneri
Copy link
Member

goneri commented Jul 1, 2021 •
edited
Loading

I see the gating is failing again. I try with a Depends-On on my "splitter" branch.

@goneri
Copy link
Member

goneri commented Jul 1, 2021

recheck

@goneri goneri closed this Jul 1, 2021
@goneri goneri reopened this Jul 1, 2021
@goneri
Copy link
Member

goneri commented Jul 1, 2021

recheck

6 similar comments
@goneri
Copy link
Member

goneri commented Jul 1, 2021

recheck

@goneri
Copy link
Member

goneri commented Jul 1, 2021

recheck

@goneri
Copy link
Member

goneri commented Jul 1, 2021

recheck

@goneri
Copy link
Member

goneri commented Jul 2, 2021

recheck

@goneri
Copy link
Member

goneri commented Jul 2, 2021

recheck

@tremble
Copy link
Contributor

tremble commented Jul 2, 2021

recheck

@tremble tremble closed this Jul 2, 2021
@tremble tremble reopened this Jul 2, 2021
@tremble
Copy link
Contributor

tremble commented Jul 2, 2021

recheck

@ansible-zuul ansible-zuul bot merged commit bd1008c into ansible-collections:main Jul 2, 2021
@jillr jillr deleted the remove_shippable branch July 2, 2021 22:45
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 15, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#563 from jillr/remov…
4c66315 
…e_shippable

Cleanup integration tests post-Zuul migration

SUMMARY
This collection has been operating on Zuul CI for some weeks now.

Remove shippable references
Use shorter unique_ids were resource_prefixes now exceed AWS resource length limits (zuul hostnames are longer than shippable was)
Cleanup for CI bugs surfaced in the course of this PR

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
shippable.yml
tests/
README.md
NOT-Depends-On: ansible/ansible-zuul-jobs#978

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@bd1008c
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 17, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#563 from jillr/remov…
992f0c6 
…e_shippable

Cleanup integration tests post-Zuul migration

SUMMARY
This collection has been operating on Zuul CI for some weeks now.

Remove shippable references
Use shorter unique_ids were resource_prefixes now exceed AWS resource length limits (zuul hostnames are longer than shippable was)
Cleanup for CI bugs surfaced in the course of this PR

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
shippable.yml
tests/
README.md
NOT-Depends-On: ansible/ansible-zuul-jobs#978

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@94be338
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#563 from jillr/remove_shippable
d09cd2a 
Cleanup integration tests post-Zuul migration

SUMMARY
This collection has been operating on Zuul CI for some weeks now.

Remove shippable references
Use shorter unique_ids were resource_prefixes now exceed AWS resource length limits (zuul hostnames are longer than shippable was)
Cleanup for CI bugs surfaced in the course of this PR

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
shippable.yml
tests/
README.md
NOT-Depends-On: ansible/ansible-zuul-jobs#978

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#563 from jillr/remove_shippable
ad8b85f 
Cleanup integration tests post-Zuul migration

SUMMARY
This collection has been operating on Zuul CI for some weeks now.

Remove shippable references
Use shorter unique_ids were resource_prefixes now exceed AWS resource length limits (zuul hostnames are longer than shippable was)
Cleanup for CI bugs surfaced in the course of this PR

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
shippable.yml
tests/
README.md
NOT-Depends-On: ansible/ansible-zuul-jobs#978

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#563 from jillr/remove_shippable
94be338 
Cleanup integration tests post-Zuul migration

SUMMARY
This collection has been operating on Zuul CI for some weeks now.

Remove shippable references
Use shorter unique_ids were resource_prefixes now exceed AWS resource length limits (zuul hostnames are longer than shippable was)
Cleanup for CI bugs surfaced in the course of this PR

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
shippable.yml
tests/
README.md
NOT-Depends-On: ansible/ansible-zuul-jobs#978

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@felixfontein
Fix docs issues. (ansible-collections#563)
004ee3a 
Fix docs issues.

SUMMARY
Fix some docs issues exhibited by ansible/ansible#76262.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
some modules

Reviewed-by: Brian Scholer <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jillr @tremble @ansibullbot @goneri