Fix KeyError in aws_config_aggregator module #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `organization_source` attribute is specified, module fails with the following error on line 206: ``` KeyError: 'OrganizationAggregationSourcep' ``` If `organization_source` attribute is specified and `account_sources` attribute is empty, module fails with the following error on line 119: ``` KeyError: 'AccountAggregationSources' ``` This PR fixes both issues.
ansibullbot
added
bug
tremble
approved these changes
Apr 25, 2021
|
I've tested this locally and it doesn't break the existing (limited) test suite. |
|
@ichekaldin thanks for your contribution. The fix will hopefully auto-merge now and should be available in the next week or two as a part of a 1.5.0 release. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…_aggregator/fix_organization_source
Fix KeyError in aws_config_aggregator module
Reviewed-by: Ansibullbot manages ticket workflow
https://github.com/ansibullbot
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…_aggregator/fix_organization_source
Fix KeyError in aws_config_aggregator module
Reviewed-by: Ansibullbot manages ticket workflow
https://github.com/ansibullbot
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ollections#553) Improve error handling rds.py for RDS cluster and snapshot SUMMARY Improve error handling rds.py for rds_cluster Add handlers for rds_instance_snapshot and rds_cluster_snapshot ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/rds.py Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Joseph Torcasso <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If
organization_sourceattribute is specified, module fails with thefollowing error on line 206:
If
organization_sourceattribute is specified andaccount_sourcesattribute is empty, module fails with the following error on line 119:
This PR fixes both issues.
ISSUE TYPE
COMPONENT NAME
aws_config_aggregator
ADDITIONAL INFORMATION
Example of an execution that triggers both errors: