Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect arguments for application session stickiness and update docs #548

Merged

Conversation

heytrav
Copy link
Contributor

@heytrav heytrav commented Apr 19, 2021

SUMMARY

Additional attributes for elb target group to support application-based session cookies

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_target_group

ADDITIONAL INFORMATION

See #513

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress docs feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 19, 2021
@heytrav heytrav changed the title WIP: Collect arguments for application session stickiness and update docs Collect arguments for application session stickiness and update docs Apr 24, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Apr 24, 2021
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heytrav thanks for taking the time to open this PR.

The change looks sensible and matches with the upstream docs. Please would you add a changelog entry and the "version_added" changes.

https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

plugins/modules/elb_target_group.py Show resolved Hide resolved
plugins/modules/elb_target_group.py Show resolved Hide resolved
plugins/modules/elb_target_group.py Outdated Show resolved Hide resolved
plugins/modules/elb_target_group.py Outdated Show resolved Hide resolved
@tremble tremble added the gate label Apr 26, 2021
@ansible-zuul ansible-zuul bot merged commit 0ac5175 into ansible-collections:main Apr 26, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 15, 2021
…-target-group-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@0ac5175
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
…-target-group-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@0ac5175
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 17, 2021
…-target-group-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@472537c
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…oup-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…oup-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…oup-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…ns#548)

ec2_key - add support for tagging and returning id

SUMMARY
Add support for tagging key pairs and also return the key ID
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_key
ADDITIONAL INFORMATION
fixes: ansible-collections#546
fixes: ansible-collections#547

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants