-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect arguments for application session stickiness and update docs #548
Merged
ansible-zuul
merged 4 commits into
ansible-collections:main
from
heytrav:elb-target-group-app-session
Apr 26, 2021
Merged
Collect arguments for application session stickiness and update docs #548
ansible-zuul
merged 4 commits into
ansible-collections:main
from
heytrav:elb-target-group-app-session
Apr 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
Work in progress
docs
feature
This issue/PR relates to a feature request
module
module
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
labels
Apr 19, 2021
heytrav
changed the title
WIP: Collect arguments for application session stickiness and update docs
Collect arguments for application session stickiness and update docs
Apr 24, 2021
tremble
requested changes
Apr 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heytrav thanks for taking the time to open this PR.
The change looks sensible and matches with the upstream docs. Please would you add a changelog entry and the "version_added" changes.
https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
tremble
approved these changes
Apr 26, 2021
tremble
reviewed
Apr 26, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…-target-group-app-session Collect arguments for application session stickiness and update docs Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@0ac5175
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…-target-group-app-session Collect arguments for application session stickiness and update docs Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@0ac5175
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…-target-group-app-session Collect arguments for application session stickiness and update docs Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@472537c
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…oup-app-session Collect arguments for application session stickiness and update docs Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…oup-app-session Collect arguments for application session stickiness and update docs Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…oup-app-session Collect arguments for application session stickiness and update docs Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ns#548) ec2_key - add support for tagging and returning id SUMMARY Add support for tagging key pairs and also return the key ID ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_key ADDITIONAL INFORMATION fixes: ansible-collections#546 fixes: ansible-collections#547 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
docs
feature
This issue/PR relates to a feature request
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Additional attributes for elb target group to support application-based session cookies
ISSUE TYPE
COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
See #513