-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves 494: added destructor to ssm connection plugin #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Chilinot,
Thanks for taking the time to dig into the issue and open this PR. If possible please could you add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
The change itself looks sensible.
Hi @tremble and @Chilinot. Thanks for this update. I have tested the proposed fix with my playbooks. Immediately after adding the proposed change I noticed that sessions were terminated properly. At the same time, looking in the AWS Session Manager console, under sessions, at most time I saw only 1 connection being open. I have repeated the test with the same playbook but before repeating I have removed the proposed change. In this instance I saw more than 20 connection remaining open even after the execution of playbooks has finished. This tells me that the fix is indeed effective. I recommend merging this PR as soon as possible! |
@tremble I have now added a changelog fragment as required. |
changelogs/fragments/542-ensure-ssm-plugin-terminates-connections.yml
Outdated
Show resolved
Hide resolved
…ons.yml Co-authored-by: Mark Chappell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll let the test suites do their thing and hopefully we can get this merged.
changelogs/fragments/542-ensure-ssm-plugin-terminates-connections.yml
Outdated
Show resolved
Hide resolved
…ons.yml Co-authored-by: Mark Chappell <[email protected]>
Tests didn't run in zuul for some reason. Tested locally and they still pass. |
@tremble What is usually the expected cadence for this merged fix to be included in a release? |
Our last release was almost 2 months ago, I'd expect 1.5.0 to land 'soon'. |
Solves 494: added destructor to ssm connection plugin Reviewed-by: https://github.com/apps/ansible-zuul
Solves 494: added destructor to ssm connection plugin Reviewed-by: https://github.com/apps/ansible-zuul
SUMMARY
Fixes #494
Adds destructor to the SSM connection plugin to ensure connections are properly cleaned up after usage.
ISSUE TYPE
COMPONENT NAME
SSM connection plugin