-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ec2_vpc_endpoint_info AWS retries #537
Update ec2_vpc_endpoint_info AWS retries #537
Conversation
ad17001
to
8acde77
Compare
recheck |
We were also seeing test failures because the tag search assumed the first result would be the result from the current test, but with tests running in parallel we were seeing multiple matches. Test updated to use a unique tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because all of the ec2 calls are paginated retry_decorator doesn't help, if there were any not-paginated calls I'd have added retry_decorator. |
…_vpc_endpoint_info/retries Update ec2_vpc_endpoint_info AWS retries Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@893d08c
…int_info/retries Update ec2_vpc_endpoint_info AWS retries Reviewed-by: https://github.com/apps/ansible-zuul
…int_info/retries Update ec2_vpc_endpoint_info AWS retries Reviewed-by: https://github.com/apps/ansible-zuul
SUMMARY
We're still seeing some failures during Integration tests because we caught ClientError before the decorator could retry it.
https://app.shippable.com/github/ansible-collections/community.aws/runs/2267/24/tests
ISSUE TYPE
COMPONENT NAME
ec2_vpc_endpoint_info
ADDITIONAL INFORMATION