Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds_param_group: fix tests, check_mode, AWSRetry #532

Merged
merged 4 commits into from
Apr 7, 2021
Merged

rds_param_group: fix tests, check_mode, AWSRetry #532

merged 4 commits into from
Apr 7, 2021

Conversation

alinabuzachis
Copy link
Contributor

  • Fix integration tests
  • Add AWSRetry
  • Add check_mode
SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_param_group

@alinabuzachis
* Fix integration tests
b01aeab 
	* Add AWSRetry
	* Add check_mode
@alinabuzachis
Add changelog fragment
11fd190 
Signed-off-by: Alina Buzachis <[email protected]>
@ansibullbot
Copy link

cc @jillr @s-hertel @scottanderson42 @tastychutney @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Apr 7, 2021
tremble
tremble requested changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor niggle (assuming the tests pass)

plugins/modules/rds_param_group.py Outdated Show resolved Hide resolved
@alinabuzachis
Add error message
aa31e9a 
Signed-off-by: Alina Buzachis <[email protected]>
@tremble tremble merged commit 579f8de into ansible-collections:main Apr 7, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
rds_param_group: fix tests, check_mode, AWSRetry (ansible-collections…
3313f5a 
…#532)

* * Fix integration tests
	* Add AWSRetry
	* Add check_mode

* Add changelog fragment

Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
rds_param_group: fix tests, check_mode, AWSRetry (ansible-collections…
daf2ce5 
…#532)

* * Fix integration tests
	* Add AWSRetry
	* Add check_mode

* Add changelog fragment

Signed-off-by: Alina Buzachis <[email protected]>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@alinabuzachis @danielcotton
rds_param_group: fix tests, check_mode, AWSRetry (ansible-collections…
80698c6 
…#532)

* * Fix integration tests
	* Add AWSRetry
	* Add check_mode

* Add changelog fragment

Signed-off-by: Alina Buzachis <[email protected]>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@alinabuzachis @goneri
rds_param_group: fix tests, check_mode, AWSRetry (ansible-collections…
aae32e7 
…#532)

* * Fix integration tests
	* Add AWSRetry
	* Add check_mode

* Add changelog fragment

Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@579f8de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alinabuzachis @ansibullbot @tremble