Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ignore-2.12.txt #527

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Apr 6, 2021

SUMMARY

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/ignore_212.yml
tests/sanity/ignore-2.12.txt

Signed-off-by: Abhijeet Kasurde <[email protected]>
@ansibullbot ansibullbot added bug This issue/PR relates to a bug needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage tests tests labels Apr 6, 2021
changelogs/fragments/ignore_212.yml Outdated Show resolved Hide resolved
@tremble
Copy link
Contributor

tremble commented Apr 6, 2021

Thanks @Akasurde

@tremble tremble merged commit 395e02b into ansible-collections:main Apr 6, 2021
@Akasurde Akasurde deleted the ignore_212 branch April 6, 2021 07:21
@Akasurde
Copy link
Member Author

Akasurde commented Apr 6, 2021

@tremble Thanks for review and merge.

alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Added ignore-2.12.txt

Signed-off-by: Abhijeet Kasurde <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Added ignore-2.12.txt

Signed-off-by: Abhijeet Kasurde <[email protected]>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
* Added ignore-2.12.txt

Signed-off-by: Abhijeet Kasurde <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…nce to use helpers (ansible-collections#527)

Add helper for generating TagSpecification lists and update ec2_instance to use helpers

SUMMARY

Moves generic tagging tools into dedicated module_utils.tagging (ensure_ec2_tags is currently EC2 specific and needs some thought to make it more generic)
Adds boto3_tag_specifications helper to generate TagSpecification lists
Migrates ec2_instance to the new helper and the ensure_ec2_tags helper.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_instance
plugins/module_utils/ec2.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants