Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efs - Add support to specify the number of days to transition to inactive storage #522

Merged
merged 6 commits into from
Oct 27, 2021
Merged

efs - Add support to specify the number of days to transition to inactive storage #522

merged 6 commits into from
Oct 27, 2021

Conversation

berenddeboer
Copy link
Contributor

@berenddeboer berenddeboer commented Apr 4, 2021 •
edited
Loading

SUMMARY

Support setting EFS lifecycle policy.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.aws.efs

ADDITIONAL INFORMATION

This is now possible:

- name: Set a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: 7
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

- name: Remove a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: None
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

@ansibullbot
Copy link

cc @akazakov @jillr @ryansydnor @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 4, 2021
tremble
tremble requested changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to raise this PR.

Change generally looks sound. Some minor formatting issues picked up by the linter.

In addition please add a changelog https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

Last time I looked the EFS integration tests were broken so it may take a while before I would be able to fully validate this change as I'm not actively using EFS at this time.

plugins/modules/efs.py Outdated Show resolved Hide resolved
plugins/modules/efs.py Outdated Show resolved Hide resolved
plugins/modules/efs.py Outdated Show resolved Hide resolved
plugins/modules/efs.py Outdated Show resolved Hide resolved
plugins/modules/efs.py Outdated Show resolved Hide resolved
@ansibullbot
Copy link

cc @markuman
click here for bot help

@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 23, 2021
@tremble tremble force-pushed the add-efs-lifecyle-support branch from 46b066c to db8ed0c Compare October 24, 2021 09:58
@tremble tremble changed the title Add support to specify the number of days to transition to inactive storage efs - Add support to specify the number of days to transition to inactive storage Oct 24, 2021
@tremble
Copy link
Contributor

tremble commented Oct 24, 2021

Depends on mattclay/aws-terminator#177

@ansibullbot ansibullbot added integration tests/integration tests tests labels Oct 24, 2021
@alinabuzachis
Copy link
Contributor

recheck

@jillr
Copy link
Collaborator

jillr commented Oct 26, 2021

recheck

@tremble tremble force-pushed the add-efs-lifecyle-support branch from b138f51 to b061ee6 Compare October 27, 2021 04:51
@tremble tremble added the gate label Oct 27, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 1c1fae3 into ansible-collections:main Oct 27, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
Refactor ec2_eni tagging code (ansible-collections#522)
a1ef229 
Refactor ec2_eni tagging code

SUMMARY
Use the shared ec2 tagging code for tagging ENIs.
Also fixes the test instability (caused by a race condition with VM states)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eni
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

@tremble tremble tremble approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@berenddeboer @ansibullbot @tremble @alinabuzachis @jillr @goneri