Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_option_group (_info) new modules #517

Merged
merged 20 commits into from
Oct 25, 2021

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Mar 31, 2021

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: #463

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

rds_option_group
rds_option_group_info

Requires: mattclay/aws-terminator#144

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Mar 31, 2021
@alinabuzachis alinabuzachis force-pushed the rds_options_group branch 2 times, most recently from 13e121b to 0ee37a1 Compare March 31, 2021 21:30
@tremble
Copy link
Contributor

tremble commented Apr 15, 2021

Creds YAML-anchor hack shouldn't be needed any more.

alinabuzachis and others added 9 commits June 3, 2021 19:35
	* Fix integration tests

Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
@ansibullbot
Copy link

@alinabuzachis
Copy link
Contributor Author

recheck

1 similar comment
@alinabuzachis
Copy link
Contributor Author

recheck

Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Copy link
Contributor Author

recheck

plugins/modules/rds_option_group.py Outdated Show resolved Hide resolved
plugins/modules/rds_option_group.py Outdated Show resolved Hide resolved
plugins/modules/rds_option_group.py Show resolved Hide resolved
plugins/modules/rds_option_group_info.py Outdated Show resolved Hide resolved
plugins/modules/rds_option_group_info.py Outdated Show resolved Hide resolved
There shouldn't be anything to describe
@tremble tremble added the gate label Oct 25, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 142836b into ansible-collections:main Oct 25, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
… support Python<3.6 (ansible-collections#517)

Add tests/config.yml to tell recent versions of ansible-test we don't support Python<3.6

SUMMARY
(Ansible 2.12) ansible-test now has a config file that lets us limit tests to those relevant to Python>=3.6
Add this to simplify things.
Unfortunately this hasn't been (and likely won't be) backported to older versions of Ansible, so there's a little while before we can drop the python 2.x compatability code, but this gets us started.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/sanity
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
rds_option_group (_info) new modules

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: ansible-collections#463

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@142836b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review has_issue integration tests/integration module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add module rds_option_group
4 participants