-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rds_option_group (_info) new modules #517
Merged
ansible-zuul
merged 20 commits into
ansible-collections:main
from
alinabuzachis:rds_options_group
Oct 25, 2021
Merged
rds_option_group (_info) new modules #517
ansible-zuul
merged 20 commits into
ansible-collections:main
from
alinabuzachis:rds_options_group
Oct 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
force-pushed
the
rds_options_group
branch
from
March 31, 2021 21:16
12c45fb
to
9e2aa97
Compare
ansibullbot
added
WIP
Work in progress
integration
tests/integration
module
module
needs_triage
new_module
New module
new_plugin
New plugin
plugins
plugin (any type)
tests
tests
labels
Mar 31, 2021
alinabuzachis
force-pushed
the
rds_options_group
branch
2 times, most recently
from
March 31, 2021 21:30
13e121b
to
0ee37a1
Compare
tremble
reviewed
Apr 1, 2021
alinabuzachis
force-pushed
the
rds_options_group
branch
2 times, most recently
from
April 1, 2021 20:28
8d7d70b
to
0ea4ec1
Compare
alinabuzachis
force-pushed
the
rds_options_group
branch
from
April 13, 2021 12:08
c5aadc1
to
68a8626
Compare
tremble
reviewed
Apr 13, 2021
Creds YAML-anchor hack shouldn't be needed any more. |
alinabuzachis
force-pushed
the
rds_options_group
branch
9 times, most recently
from
April 19, 2021 21:01
8f599c3
to
bdf10ce
Compare
* Fix integration tests Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
rds_options_group
branch
from
June 3, 2021 17:39
7890fc2
to
a82851f
Compare
Signed-off-by: Alina Buzachis <[email protected]>
recheck |
1 similar comment
recheck |
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
rds_options_group
branch
from
August 13, 2021 09:39
b4e6678
to
cf078bc
Compare
recheck |
tremble
approved these changes
Oct 25, 2021
tremble
approved these changes
Oct 25, 2021
There shouldn't be anything to describe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
… support Python<3.6 (ansible-collections#517) Add tests/config.yml to tell recent versions of ansible-test we don't support Python<3.6 SUMMARY (Ansible 2.12) ansible-test now has a config file that lets us limit tests to those relevant to Python>=3.6 Add this to simplify things. Unfortunately this hasn't been (and likely won't be) backported to older versions of Ansible, so there's a little while before we can drop the python 2.x compatability code, but this gets us started. ISSUE TYPE Feature Pull Request COMPONENT NAME tests/sanity ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds_option_group (_info) new modules SUMMARY Attempt to resurrect ansible/ansible#25290 Fixes: ansible-collections#463 ISSUE TYPE New Module Pull Request COMPONENT NAME rds_option_group rds_option_group_info Requires: mattclay/aws-terminator#144 Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@142836b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
has_issue
integration
tests/integration
module
module
new_module
New module
new_plugin
New plugin
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Attempt to resurrect ansible/ansible#25290
Fixes: #463
ISSUE TYPE
COMPONENT NAME
rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144