Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_instance - fix idempotency when using non-lowercase for preferred_maintenance_window #516

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 31, 2021

SUMMARY

Rather than relying on changing the docs (#310) force the day of the week into lowercase so that it matches what AWS returns.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Mar 31, 2021
@tremble
Copy link
Contributor Author

tremble commented Mar 31, 2021

note: tests fail without #515

Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only changelog needs link the the correct pr. otherwise LGTM

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Apr 1, 2021
@tremble tremble force-pushed the rds_instance/preferred_maintenance_window branch from d7797de to 6b89a47 Compare April 7, 2021 10:53
@tremble tremble force-pushed the rds_instance/preferred_maintenance_window branch from 6b89a47 to 713219b Compare April 7, 2021 11:50
@tremble
Copy link
Contributor Author

tremble commented Apr 7, 2021

Tests also need #531 for the full suite to run.

@tremble tremble requested a review from alinabuzachis April 7, 2021 11:52
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tremble tremble merged commit 8fbfead into ansible-collections:main Apr 9, 2021
@tremble
Copy link
Contributor Author

tremble commented Apr 9, 2021

Thanks for the reviews @markuman @alinabuzachis

@tremble tremble deleted the rds_instance/preferred_maintenance_window branch June 29, 2021 12:58
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
ec2_ami: Add check_mode support to ec2_ami

SUMMARY

Add check_mode support to ec2_ami.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_ami

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@8fbfead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants