Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudtrail - Fix changed = true when kms key alias used #506

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

msven
Copy link
Contributor

@msven msven commented Mar 27, 2021

SUMMARY

Fixes all bugs listed in the integration tests.

- output.exists == false when creating
- Changed reports true when using a KMS alias
- Tags Keys are being lower-cased

The implementation for the the changed = true fix requires no additional iam permissions, except for in the case where check_mode = true. In this case, it will use the kms:ListAliases permission if possible. I used this permission specifically because it is one of the kms permissions included in the aws managed policy arn:aws:iam::aws:policy/AWSCloudTrail_FullAccess. However, if the user does not have this permission then the module will fallback to its current behavior of reporting changed = true when check_mode = true and a kms key alias is used.

Fixes #246

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudtrail

ADDITIONAL INFORMATION

Fix output.exists value on create

Fix tags being changed to lower case

add changelog
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Mar 27, 2021
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your submission.

@tremble tremble merged commit b825069 into ansible-collections:main Mar 31, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
)

Fix output.exists value on create

Fix tags being changed to lower case

add changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
)

Fix output.exists value on create

Fix tags being changed to lower case

add changelog
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
)

Fix output.exists value on create

Fix tags being changed to lower case

add changelog
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
)

Fix output.exists value on create

Fix tags being changed to lower case

add changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b825069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudtrail Always Reports Changed=True When KMS Key Alias is used
3 participants