-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new enableExecuteCommand options for ECS service #488
Support new enableExecuteCommand options for ECS service #488
Conversation
95cb661
to
3dad1cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Surgo
Thanks for taking the time to open this PR. A couple of minor tweaks.
Please also include a changelog entry https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
* cloud.py re-implementation Co-authored-by: Mark Chappell <[email protected]>
3dad1cc
to
972c55a
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
30b2716
to
b71c1b0
Compare
b71c1b0
to
62ba163
Compare
62ba163
to
dbc05f5
Compare
@markuman I've just rebased this against main, could you take a look please. Looks like it should be a quick merge. |
dbc05f5
to
c9dd4d5
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 42s |
c9dd4d5
to
0a0fb6e
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 05s |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 06s |
644d162
to
a1d0b79
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 15s |
regate |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1752 🤖 @patchback |
Support new enableExecuteCommand options for ECS service SUMMARY Support new ecs exec feature for ECS service ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Create ECS service with enable_execute_command option, - name: create exec service ecs_service: state: present ... enable_execute_command: true and we can exec ECS task $ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash The Session Manager plugin was installed successfully. Use the AWS CLI to start a session. Starting session with SessionId: ecs-execute-command-0c17f94b36227381f root@ip-10-0-66-68:/# Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit 3ad3b97)
…d options for ECS service (#1752) [PR #488/3ad3b97f backport][stable-5] Support new enableExecuteCommand options for ECS service This is a backport of PR #488 as merged into main (3ad3b97). SUMMARY Support new ecs exec feature for ECS service ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Create ECS service with enable_execute_command option, - name: create exec service ecs_service: state: present ... enable_execute_command: true and we can exec ECS task $ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash The Session Manager plugin was installed successfully. Use the AWS CLI to start a session. Starting session with SessionId: ecs-execute-command-0c17f94b36227381f root@ip-10-0-66-68:/# Reviewed-by: Mark Chappell
SUMMARY
ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
Create ECS service with
enable_execute_command
option,and we can exec ECS task